aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 51893: Allow cookie based authentication
Date Thu, 15 Sep 2016 07:27:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/#review149031
-----------------------------------------------------------



Master (5069f93) is red with this patch.
  ./build-support/jenkins/build.sh

  Running setup.py bdist_wheel for twitter.common.options: finished with status 'done'
  Stored in directory: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/60/c2/40/54b323809df9598cc125f02527f93ff743cd9bd979f4a1737d
Successfully built pantsbuild.pants ansicolors setproctitle twitter.common.collections pathspec
twitter.common.dirutil pystache scandir psutil pywatchman Markdown Pygments docutils twitter.common.confluence
coverage pytest pytest-cov lmdb twitter.common.lang twitter.common.log cov-core twitter.common.options
Installing collected packages: ansicolors, setproctitle, twitter.common.lang, twitter.common.collections,
six, pathspec, twitter.common.dirutil, requests, pystache, scandir, psutil, pywatchman, futures,
setuptools, pex, Markdown, Pygments, docutils, twitter.common.options, twitter.common.log,
twitter.common.confluence, monotonic, fasteners, coverage, py, pytest, cov-core, pytest-cov,
lmdb, pantsbuild.pants
  Found existing installation: setuptools 21.2.1
    Uninstalling setuptools-21.2.1:
      Successfully uninstalled setuptools-21.2.1
Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 cov-core-1.15.0 coverage-3.7.1
docutils-0.12 fasteners-0.14.1 futures-3.0.5 lmdb-0.89 monotonic-1.2 pantsbuild.pants-1.1.0rc7
pathspec-0.3.4 pex-1.1.10 psutil-4.3.0 py-1.4.31 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1
pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 setuptools-5.4.1 six-1.10.0
twitter.common.collections-0.3.7 twitter.common.confluence-0.3.7 twitter.common.dirutil-0.3.7
twitter.common.lang-0.3.7 twitter.common.log-0.3.7 twitter.common.options-0.3.7

07:27:04 00:00 [main]
               (To run a reporting server: ./pants server)
07:27:04 00:00   [setup]
07:27:04 00:00     [parse]
               Executing tasks in goals: compile
07:27:05 00:01   [compile]
07:27:05 00:01     [compile-prep-command]
07:27:05 00:01     [compile]
07:27:05 00:01     [python-eval]
07:27:05 00:01     [pythonstyle]
07:27:05 00:01       [cache]                                          
                   No cached artifacts for 42 targets.
                   Invalidated 42 targets.
F401:ERROR   src/main/python/apache/aurora/client/api/scheduler_client.py:017 'sys' imported
but unused
     |import sys

T001:ERROR   src/main/python/apache/aurora/client/api/scheduler_client.py:054 Class globals
must be UPPER_SNAKE_CASED
     |  cookie_jar        = String  #noqa

E221:ERROR   PythonFile(src/main/python/apache/aurora/client/api/scheduler_client.py):054
multiple spaces before operator
     |  cookie_jar        = String  #noqa

E262:ERROR   PythonFile(src/main/python/apache/aurora/client/api/scheduler_client.py):054
inline comment should start with '# '
     |  cookie_jar        = String  #noqa


FAILURE: 4 Python Style issues found


07:27:24 00:20   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 15, 2016, 7:17 a.m., Giulio Eulisse wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51893/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 7:17 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and WarnerSM WarnerSM.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This allows aurora client to connect to servers which are behind a
> frontend which expects some sort of cookie to autheticate and authorize
> users.
> 
> A cookie_jar option can be specified in the `~/.aurora/clusters.json`
> to specify a file where the cookie jar is located. Such a cookie jar,
> in MozillanCookieJar format, will be used to create the session and
> therefore all the subsequent requests will use it.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py cbdb50ae409b70a35a03405f969d02a6145c9c53

> 
> Diff: https://reviews.apache.org/r/51893/diff/
> 
> 
> Testing
> -------
> 
> $ cat ~/aurora/clusters.json
> [
> {
>   "name": "build",
>   "scheduler_uri": "https://aliaurora.cern.ch",
>   "auth_mechanism": "UNAUTHENTICATED",
>   "cookie_jar": "~/.aurora-token"
> }
> ]
> $ dist/aurora.pex quota get build/root
> 
> 
> Thanks,
> 
> Giulio Eulisse
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message