aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'
Date Wed, 14 Sep 2016 00:53:43 GMT


> On Sept. 13, 2016, 5:11 p.m., Zameer Manji wrote:
> > I support this change as a developer.
> > 
> > As an operator I am scared.
> > 
> > What happens to an existing cluster if we don't set `framework_name`? Will it register
another frameowork_id? (bad) or will it fail to register? (better).
> 
> Santhosh Kumar Shanmugham wrote:
>     The restarting framework will be treated like a scheduler fail-over.

The release notes in this patch says
> Update default value of command line option `-framework_name` to 'aurora'. Please be
aware that
  depending on your usage of Mesos, this will be a backward incompatible change.
  
I'm trying to understand the implications of the backwards incompatability. Will the scheduler
fail to register or will it register under a new frameworkid (and then lose track of previous
tasks?)


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51874/#review148816
-----------------------------------------------------------


On Sept. 13, 2016, 5:18 p.m., Santhosh Kumar Shanmugham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51874/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2016, 5:18 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1688
>     https://issues.apache.org/jira/browse/AURORA-1688
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Change framework_name default value from 'TwitterScheduler' to 'aurora'
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md ad2c68a6defe07c94480d7dee5b1496b50dc34e5 
>   src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
8a386bd208956eb0c8c2f48874b0c6fb3af58872 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 97677f24a50963178a123b420d7ac136e4fde3fe

> 
> Diff: https://reviews.apache.org/r/51874/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message