aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery
Date Mon, 12 Sep 2016 22:47:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51712/#review148616
-----------------------------------------------------------



Master (c4903d8) is red with this patch.
  ./build-support/jenkins/build.sh

                             # Create file stdout for capturing output. We can't use StringIO
mock
                             # because TestProcess is running fork.
                             with open(os.path.join(td, 'sys_stdout'), 'w+') as stdout:
                               with open(os.path.join(td, 'sys_stderr'), 'w+') as stderr:
                                 with mutable_sys():
                                   sys.stdout, sys.stderr = stdout, stderr
                         
                                   p = TestProcess('process', 'echo hello world; echo
>&2 hello stderr', 0,
                                                   taskpath, sandbox, logger_destination=LoggerDestination.BOTH)
                                   p.start()
                                   rc = wait_for_rc(taskpath.getpath('process_checkpoint'))
                         
                                   assert rc == 0
                                   # Check log files were created in std path with correct
content
                     >             assert_log_content(taskpath, 'stdout', 'hello world\n')
                     
                     src/test/python/apache/thermos/core/test_process.py:487: 
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     taskpath = <apache.thermos.common.path.TaskPath object at 0x7f4c2da51c50>
                     log_name = 'stdout'
                     expected_content = 'hello world\n'
                     
                         def assert_log_content(taskpath, log_name, expected_content):
                           log = taskpath.with_filename(log_name).getpath('process_logdir')
                           assert os.path.exists(log)
                           with open(log, 'r') as fp:
                     >       assert fp.read() == expected_content
                     E       assert '' == 'hello world\n'
                     E         + hello world
                     
                     src/test/python/apache/thermos/core/test_process.py:313: AssertionError
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

                      1 failed, 700 passed, 6 skipped, 1 warnings in 367.18 seconds

                     
FAILURE


22:46:52 06:41   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 12, 2016, 10:26 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51712/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 10:26 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1764
>     https://issues.apache.org/jira/browse/AURORA-1764
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This extends getJobUpdateDetails to return a list of details instead of being scoped
to a single update.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md bbf7198dc7ce53bb02a1bc59f75a661e23472913 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c5765b70501c101f0535b4eed94e9948c36808f9

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 4202f0eec59ef16668fca6b6ebb925335ad5dea1

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 929d021a336c6a3438613c9340c84a1096dc9069

>   src/main/python/apache/aurora/client/api/__init__.py 9149c3018ae58d405f284fcbd4076d251ccc8192

>   src/main/python/apache/aurora/client/cli/update.py d23243dcf93dd82f66b4c8cc4342bd2c8d2adc79

>   src/main/resources/scheduler/assets/js/services.js 315fc17894c2261333715fbb9c45fc02505f2942

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java a7d1f74acdfe5f58eb822a4d826e920cad53dced

>   src/test/python/apache/aurora/client/api/test_api.py 7a0797d5402e931006d4f215e2d9c0dbbd113257

>   src/test/python/apache/aurora/client/cli/test_supdate.py 92fb039fb7d3e368d7c0dfa5ebdb465c7f112416

> 
> Diff: https://reviews.apache.org/r/51712/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message