aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <ma...@apache.org>
Subject Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery
Date Mon, 12 Sep 2016 19:48:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51712/#review148565
-----------------------------------------------------------




src/main/python/apache/aurora/client/api/__init__.py (line 264)
<https://reviews.apache.org/r/51712/#comment216022>

    Why not going all the way to the client command and initializing both values in this changelist?
Otherwise, there is a risk of cutting a release in between and delaying removal by extra release
(until both client and scheduler are dual writing/reading).


- Maxim Khutornenko


On Sept. 12, 2016, 7:39 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51712/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 7:39 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1764
>     https://issues.apache.org/jira/browse/AURORA-1764
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This extends getJobUpdateDetails to return a list of details instead of being scoped
to a single update.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md bbf7198dc7ce53bb02a1bc59f75a661e23472913 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c5765b70501c101f0535b4eed94e9948c36808f9

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 4202f0eec59ef16668fca6b6ebb925335ad5dea1

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 929d021a336c6a3438613c9340c84a1096dc9069

>   src/main/python/apache/aurora/client/api/__init__.py 9149c3018ae58d405f284fcbd4076d251ccc8192

>   src/main/resources/scheduler/assets/js/services.js 315fc17894c2261333715fbb9c45fc02505f2942

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java a7d1f74acdfe5f58eb822a4d826e920cad53dced

>   src/test/python/apache/aurora/client/api/test_api.py 7a0797d5402e931006d4f215e2d9c0dbbd113257

> 
> Diff: https://reviews.apache.org/r/51712/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message