aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <ma...@apache.org>
Subject Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources
Date Mon, 12 Sep 2016 19:31:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51807/#review148563
-----------------------------------------------------------




src/main/java/org/apache/aurora/scheduler/resources/ResourceSettings.java (lines 22 - 33)
<https://reviews.apache.org/r/51807/#comment216016>

    This is somewhat non-standard way to define cmd flags. We tend to declare them in modules
and use 'setting' classes to act as pure wrappers. Perhaps it's time to introduce a `ResourceModule`
class (if only to bind the `ResourceSettings` instance for now)?



src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java (line 75)
<https://reviews.apache.org/r/51807/#comment216017>

    Would be great to have a e2e test when this functionality is available in Mesos. Perhaps
drop a TODO here?


- Maxim Khutornenko


On Sept. 12, 2016, 1:38 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51807/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 1:38 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We plan to open source a very simple Mesos ResourceEstimator and QosController that supports
RAM and CPU oversubscription (ETA ~2 weeks). We have been using it internally with a patched
Aurora version where the hardcoded `isMesosRevocable` flag of RAM has been set to `true`.
This patch makes this behaviour configurable.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md bbf7198dc7ce53bb02a1bc59f75a661e23472913 
>   docs/features/resource-isolation.md 01c5b407a4964e89741d0f6c72d04ab5dc4c2f87 
>   docs/operations/configuration.md 90dde574ce517355d2d6045a5ab036c1a3838882 
>   docs/reference/scheduler-configuration.md 87d2cded0780ffa34884b52cc049c6a0ad808f0a

>   src/main/java/org/apache/aurora/scheduler/resources/ResourceSettings.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 4c102a3d4c4bdd27a1d0536b689acd6257e77788

> 
> Diff: https://reviews.apache.org/r/51807/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message