aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation
Date Mon, 12 Sep 2016 18:59:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51662/#review148549
-----------------------------------------------------------


Ship it!




lgtm modulo the below.

Thanks for iterating Karthik!


src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java (lines 654
- 656)
<https://reviews.apache.org/r/51662/#comment216008>

    you can use `Preconditions#checkArgument` here.



src/main/python/apache/aurora/admin/admin.py (lines 356 - 359)
<https://reviews.apache.org/r/51662/#comment216012>

    I still don't like defaulting to `explicit` if the value is not `implicit`. It could lead
to unexpected behavior if the option is changed without updating the code here. Instead we
should:
    
        if optiona.type == 'implicit':
          ...
        elif options.type == 'explicit':
          ...
        else:
          die('Unexpected value for --type: %s' % options.type)


- Joshua Cohen


On Sept. 12, 2016, 5:49 p.m., Karthik Anantha Padmanabhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51662/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 5:49 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1602 Aurora admin commands for reconcilation
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md bbf7198dc7ce53bb02a1bc59f75a661e23472913 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c5765b70501c101f0535b4eed94e9948c36808f9

>   src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 3275d72a0a74909e635bce615e2036ec72aa38ee

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 929d021a336c6a3438613c9340c84a1096dc9069

>   src/main/python/apache/aurora/admin/admin.py 76009b9c1c7a130c25abad544a176dc590dafb12

>   src/main/python/apache/aurora/client/api/__init__.py 9149c3018ae58d405f284fcbd4076d251ccc8192

>   src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java b9317dc20456f90057ec2bf4d10619a5ae986187

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
779dc302602ae8842084807ca868a491ea99b676 
>   src/test/python/apache/aurora/admin/test_admin.py eb193c4a33f5275f05a995338446bec0e19bc1cf

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py afac2500551af2fce406bb906aa4e33f353e90a1

> 
> Diff: https://reviews.apache.org/r/51662/diff/
> 
> 
> Testing
> -------
> 
> * Manually tested on my local vagrant installation
> * ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Karthik Anantha Padmanabhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message