aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kai Huang <texasred2...@hotmail.com>
Subject Re: Review Request 51742: Modify the callback function passed to StatusManager
Date Thu, 08 Sep 2016 20:07:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51742/
-----------------------------------------------------------

(Updated Sept. 8, 2016, 8:07 p.m.)


Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.


Changes
-------

Updated bugs related to this review request.


Bugs: AURORA-1225
    https://issues.apache.org/jira/browse/AURORA-1225


Repository: aurora


Description
-------

Modify the callback function passed to StatusManager to handle more StatusResult.

Currently, Aurora executor passes a callback to a status manager. The status manager periodically
polls the status of HealthChecker. When a non-empty status is deteted, the callback function
will shut down the status manager. 

In health check driven updates, the health checker will change its status to "TASK_RUNNING"
when a successful required number of health checks is reached. Therefore, we need to modify
the callback function, so that it won't shutdown the status manager if the task is in non-exit
state like "TASK_RUNNING".

Please see this epic: https://issues.apache.org/jira/browse/AURORA-1225
and the design doc: https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
for more details and background.


Diffs
-----

  src/main/python/apache/aurora/executor/aurora_executor.py ce5ef680f01831cd89fced8969ae3246c7f60cfd

  src/main/python/apache/aurora/executor/status_manager.py 228a99a05f339e21cd7e769a42b9b2276e7bc3fc

  src/test/python/apache/aurora/executor/test_status_manager.py ce4679ba1aa7b42cf0115c943d84663030182d23


Diff: https://reviews.apache.org/r/51742/diff/


Testing
-------

./gradlew build

./build-support/jenkins/build.sh


Thanks,

Kai Huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message