aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation
Date Thu, 08 Sep 2016 18:43:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51662/#review148230
-----------------------------------------------------------




src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java (line 167)
<https://reviews.apache.org/r/51662/#comment215711>

    Don't we need tests specific to 'reconciliation' here too?



src/test/python/apache/aurora/admin/test_admin.py (line 228)
<https://reviews.apache.org/r/51662/#comment215703>

    s/get_scheduler/reconcile



src/test/python/apache/aurora/admin/test_admin.py (line 248)
<https://reviews.apache.org/r/51662/#comment215704>

    s/get_scheduler/reconcile



src/test/python/apache/aurora/admin/test_admin.py (line 265)
<https://reviews.apache.org/r/51662/#comment215708>

    Should this also be assert_called_once_with(None) ?



src/test/python/apache/aurora/admin/test_admin.py (line 268)
<https://reviews.apache.org/r/51662/#comment215705>

    s/get_scheduler/reconcile



src/test/python/apache/aurora/admin/test_admin.py (line 285)
<https://reviews.apache.org/r/51662/#comment215709>

    Should this also be assert_called_once_with(None) ?


- Santhosh Kumar Shanmugham


On Sept. 8, 2016, 10:27 a.m., Karthik Anantha Padmanabhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51662/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2016, 10:27 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1602 Aurora admin commands for reconcilation
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md bbf7198dc7ce53bb02a1bc59f75a661e23472913 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c5765b70501c101f0535b4eed94e9948c36808f9

>   src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 3275d72a0a74909e635bce615e2036ec72aa38ee

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 929d021a336c6a3438613c9340c84a1096dc9069

>   src/main/python/apache/aurora/admin/admin.py 76009b9c1c7a130c25abad544a176dc590dafb12

>   src/main/python/apache/aurora/client/api/__init__.py 9149c3018ae58d405f284fcbd4076d251ccc8192

>   src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java b9317dc20456f90057ec2bf4d10619a5ae986187

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
779dc302602ae8842084807ca868a491ea99b676 
>   src/test/python/apache/aurora/admin/test_admin.py eb193c4a33f5275f05a995338446bec0e19bc1cf

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py afac2500551af2fce406bb906aa4e33f353e90a1

> 
> Diff: https://reviews.apache.org/r/51662/diff/
> 
> 
> Testing
> -------
> 
> * Manually tested on my local vagrant installation
> * ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Karthik Anantha Padmanabhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message