aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery
Date Thu, 08 Sep 2016 00:24:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51712/#review148119
-----------------------------------------------------------



Master (8fca745) is red with this patch.
  ./build-support/jenkins/build.sh

                     src/test/python/apache/thermos/common/test_planner.py::test_planner_ordered
PASSED
                     src/test/python/apache/thermos/common/test_planner.py::test_planner_mixed
PASSED
                     src/test/python/apache/thermos/common/test_planner.py::test_planner_unsatisfiables
PASSED
                     
                     ==================== FAILURES ====================
                     _ TestJobUpdateApis.test_get_job_update_details __
                     
                     self = <aurora.client.api.test_api.TestJobUpdateApis testMethod=test_get_job_update_details>
                     
                         def test_get_job_update_details(self):
                           """Test getting job update details."""
                           api, mock_proxy = self.mock_api()
                           key = JobUpdateKey(job=JobKey(role="role", environment="env",
name="name"), id="id")
                     >     api.get_job_update_details(key)
                     
                     src/test/python/apache/aurora/client/api/test_api.py:192: 
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     .pants.d/python-setup/chroots/8f4bc6d10c5c0a60369568c5d2b7748b7e500f99/apache/aurora/client/api/__init__.py:264:
in get_job_update_details
                         return self._scheduler_proxy.getJobUpdateDetails(key)
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     _mock_self = <MagicMock name='mock.getJobUpdateDetails' spec_set='instancemethod'
id='140283167863184'>
                     args = (JobUpdateKey(job=JobKey(environment='env', role='role', name='name'),
id='id'),)
                     kwargs = {}
                     
                         def __call__(_mock_self, *args, **kwargs):
                             # can't use self in-case a function / method we are mocking
uses self
                             # in the signature
                     >       _mock_self._mock_check_sig(*args, **kwargs)
                     E       TypeError: <lambda>() takes exactly 3 arguments
(2 given)
                     
                     .pants.d/python-setup/chroots/8f4bc6d10c5c0a60369568c5d2b7748b7e500f99/.deps/mock-1.0.1-py2-none-any.whl/mock.py:954:
TypeError
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

                      1 failed, 700 passed, 6 skipped, 1 warnings in 226.75 seconds

                     
FAILURE


00:24:19 04:19   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 8, 2016, 12:03 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51712/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2016, 12:03 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1764
>     https://issues.apache.org/jira/browse/AURORA-1764
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This extends getJobUpdateDetails to return a list of details instead of being scoped
to a single update.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md d79aaadc197697d09a71c83494a01765d6a983d4 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c5765b70501c101f0535b4eed94e9948c36808f9

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 4202f0eec59ef16668fca6b6ebb925335ad5dea1

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 929d021a336c6a3438613c9340c84a1096dc9069

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java a7d1f74acdfe5f58eb822a4d826e920cad53dced

> 
> Diff: https://reviews.apache.org/r/51712/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message