aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Review Request 51615: Upgrade to latest CherryPy.
Date Fri, 02 Sep 2016 20:55:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51615/
-----------------------------------------------------------

Review request for Aurora and Stephan Erb.


Repository: aurora


Description
-------

We can now move past the UTF-8 encoding issues of 6.0.0 - 7.1.0 since
the UTF-8 encoded test filename was removed from the package here:
  https://github.com/cherrypy/cherrypy/commit/b8e2518d

See the changelog here:
  https://github.com/cherrypy/cherrypy/blob/v8.0.0/CHANGES.txt

 3rdparty/python/requirements.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Diffs
-----

  3rdparty/python/requirements.txt 1d587cff73a274bcca8dcd5782dbbf26093e4440 

Diff: https://reviews.apache.org/r/51615/diff/


Testing
-------

Found this very recent fix while working
https://github.com/pantsbuild/pants/issues/3823 on the pants/pex side.

Now green:
  `LANG=en_US.ISO-8859-1 ./pants test src/{main,test}/python::`


Thanks,

John Sirois


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message