aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.
Date Thu, 01 Sep 2016 23:49:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51564/#review147617
-----------------------------------------------------------



Master (bd11b1c) is red with this patch.
  ./build-support/jenkins/build.sh

23:49:08 00:00     [parse]
               Executing tasks in goals: compile
23:49:08 00:00   [compile]
23:49:08 00:00     [compile-prep-command]
23:49:08 00:00     [compile]
23:49:08 00:00     [python-eval]
23:49:08 00:00     [pythonstyle]
23:49:09 00:01       [cache]                                          
                   No cached artifacts for 42 targets.
                   Invalidated 42 targets.
T100:ERROR   src/main/python/apache/aurora/executor/common/sandbox.py:222-224 Indentation
of 3 instead of 2
     |       raise self.CreationError(
     |          'Group id result %s from task image does not match expected name %s and id
%s' % (
     |          result, group_name, group_id))

E501:ERROR   PythonFile(src/main/python/apache/aurora/executor/common/sandbox.py):270 line
too long (101 > 100 characters)
     |          self._verify_user_match_in_taskfs(pwent.pw_uid, pwent.pw_name, pwent.pw_gid,
grent.gr_name)


E501:ERROR   PythonFile(src/test/python/apache/aurora/executor/common/test_sandbox.py):160
line too long (108 > 100 characters)
     |    mock_check_output.assert_called_with(['chroot', sandbox._task_fs_root, 'getent',
'group', 'test-group'])

E501:ERROR   PythonFile(src/test/python/apache/aurora/executor/common/test_sandbox.py):272
line too long (104 > 100 characters)
     |@mock.patch('apache.aurora.executor.common.sandbox.FileSystemImageSandbox._verify_user_match_in_taskfs')

E501:ERROR   PythonFile(src/test/python/apache/aurora/executor/common/test_sandbox.py):279
line too long (105 > 100 characters)
     |@mock.patch('apache.aurora.executor.common.sandbox.FileSystemImageSandbox._verify_group_match_in_taskfs')

E501:ERROR   PythonFile(src/test/python/apache/aurora/executor/common/test_sandbox.py):286
line too long (104 > 100 characters)
     |@mock.patch('apache.aurora.executor.common.sandbox.FileSystemImageSandbox._verify_user_match_in_taskfs')

E501:ERROR   PythonFile(src/test/python/apache/aurora/executor/common/test_sandbox.py):293
line too long (105 > 100 characters)
     |@mock.patch('apache.aurora.executor.common.sandbox.FileSystemImageSandbox._verify_group_match_in_taskfs')


FAILURE: 7 Python Style issues found


23:49:30 00:22   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 1, 2016, 11:38 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51564/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2016, 11:38 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Bugs: AURORA-1761
>     https://issues.apache.org/jira/browse/AURORA-1761
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow E_NAME_IN_USE in useradd/groupadd.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/sandbox.py a172691e164cf64792f65f049d698f9758336542

>   src/test/python/apache/aurora/executor/common/test_sandbox.py 57ab39e2444100c3a689bb0ff745c62f7bc2f1a6

> 
> Diff: https://reviews.apache.org/r/51564/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message