aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kai Huang <texasred2...@hotmail.com>
Subject Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric
Date Thu, 01 Sep 2016 20:19:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/
-----------------------------------------------------------

(Updated Sept. 1, 2016, 8:19 p.m.)


Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.


Changes
-------

This review request depends on 51536


Repository: aurora


Description
-------

A new MTTS (Median Time To Starting) metric is added to the sla module in addition to MTTA
and MTTR.

This review request is related to my previous review request: https://reviews.apache.org/r/51536

In the new implementation, the executor starts health check at STARTING, if a successful health
check is performed before initial_interval_sec expires, it transitions into RUNNING state.
Therefore, MTTS gives us an idea of how long it takes for a task to become active, whereas
the difference between MTTR and MTTS represents the warm-up period for a task.

See the following issues for more backgrounds:

https://issues.apache.org/jira/browse/AURORA-1221

https://issues.apache.org/jira/browse/AURORA-1222

The new metrics represents the median time spent waiting for a set of tasks to reach STARTING
status within a time frame(including the tasks turning into RUNNING state within the time
frame).

Here I regard STARTING as an active state. However, STARTING state is account for platform
and job uptime calculations.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e

  src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 4f243aab5a2c2f86ec795025e86302a09f864e2d

  src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 90ea3a169dadc72e7d7493544ab865ec59d4d425


Diff: https://reviews.apache.org/r/51580/diff/


Testing
-------

./gradlew build

./gradlew :test --tests "org.apache.aurora.scheduler.updater.InstanceUpdaterTest"

./build-support/jenkins/build.sh


Thanks,

Kai Huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message