aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kai Huang <texasred2...@hotmail.com>
Subject Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled
Date Wed, 31 Aug 2016 22:08:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51536/
-----------------------------------------------------------

(Updated Aug. 31, 2016, 10:08 p.m.)


Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.


Changes
-------

Add a constant to api.thrift for health.

Rename a couple of method names in InstanceUpdaterTest.

Some style improvements.


Repository: aurora


Description
-------

- Scheduler updater will not use watch_sec if health check is enabled
- Add unit tests for successful updates.

This feature intends to improve reliability and performance of the Aurora scheduler job updater
by relying on health check status rather than watch_secs timeout when deciding an individual
instance update state. 

See this epic: https://issues.apache.org/jira/browse/AURORA-894 
and the design doc: https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
for more details and background.


Assumptions on executor change:
The executor starts health check at STARTING, if a successful health check is performed before
initial_interval_sec expires, the executor will sends a status message for RUNNING.

What I try to implement:
vCurrent updater will infer the executor version from the presence of a status message sent
by the executor during RUNNING status update. 

For vPrev executor:
    The vCurrent updater will use watch_sec for instance update, this is independent from
the health check.
For vCurrent executor:
    If health check is disabled on vCurrent executor, the vCurrent updater will use watch_sec
for instance update.
    If health check is enabled on vCurrent executor, the vCurrent updater will not use watch_sec
for instance update.


Diffs (updated)
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift c5765b70501c101f0535b4eed94e9948c36808f9

  src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java c129896d8cd54abd2634e2a339c27921042b0162

  src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java c78c7fbd7d600586136863c99ce3d7387895efee


Diff: https://reviews.apache.org/r/51536/diff/


Testing
-------

./gradlew build

./gradlew :test --tests "org.apache.aurora.scheduler.updater.InstanceUpdaterTest"

./build-support/jenkins/build.sh


Thanks,

Kai Huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message