aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 51499: Update 3dparty Python dependencies
Date Tue, 30 Aug 2016 20:35:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51499/#review147353
-----------------------------------------------------------


Ship it!




Overall LGTM. A few suggestions/comments:
* In your commit message, please point to this changelog for cherrypy: https://github.com/cherrypy/cherrypy/blob/v5.6.0/CHANGES.txt
* s/date/dare in your commit message.
* I'm a little uncomfortable for the major version bump with psutil (I think we have been
bit by this before) but the changelog indicates nothing that conerns me. Just saying that
if the executor/observer behavious abnormally after this change, it's likely because of that.

- Zameer Manji


On Aug. 30, 2016, 12:40 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51499/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2016, 12:40 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I have skimmed the changelogs and there does not seem to be anything
> worth calling out in particular. Full changelogs:
> 
> * https://github.com/cherrypy/cherrypy/blob/v7.1.0/CHANGES.txt
> * http://docs.makotemplates.org/en/latest/changelog.html
> * https://github.com/pantsbuild/pex/blob/v1.1.14/CHANGES.rst
> * https://github.com/giampaolo/psutil/blob/release-4.3.0/HISTORY.rst
> * https://github.com/requests/requests-kerberos/blob/v0.10.0/HISTORY.rst
> * https://github.com/kennethreitz/requests/blob/v2.11.1/HISTORY.rst
> 
> 
> I have skipped the following updates for now:
> 
> * bottle: has a conflicting requirement in common
> * mock: it leads to some test failures
> * thrift: I didn't date to touch that
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt 5cc3cb1edf7dcf30e44ff094e90286df48fa445e 
> 
> Diff: https://reviews.apache.org/r/51499/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message