aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <ma...@apache.org>
Subject Re: Review Request 51535: Fix a Python unittest that is not asserting anything
Date Tue, 30 Aug 2016 20:02:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51535/#review147346
-----------------------------------------------------------


Ship it!




Good catch!

- Maxim Khutornenko


On Aug. 30, 2016, 7:15 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51535/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2016, 7:15 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I discovered this one during a failed attempt to update to a new mock version. I have
only aimed for a minimal fix:
> 
> * incorrect usage of PropertyMock: https://docs.python.org/dev/library/unittest.mock.html#unittest.mock.PropertyMock
 
> * assert_called_once() does not exist: https://engineeringblog.yelp.com/2015/02/assert_called_once-threat-or-menace.html
> 
> 
> Diffs
> -----
> 
>   src/test/python/apache/aurora/admin/test_admin.py fd3b91938b5b67ea59d3955dd94a046b3181be2d

> 
> Diff: https://reviews.apache.org/r/51535/diff/
> 
> 
> Testing
> -------
> 
> Made sure it fails if the production method is tempered with.
> ./pants test.pytest src/test/python/apache/aurora/admin::
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message