aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.
Date Tue, 30 Aug 2016 20:00:35 GMT


> On Aug. 30, 2016, 12:23 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java,
line 78
> > <https://reviews.apache.org/r/51506/diff/1/?file=1488296#file1488296line78>
> >
> >     I suggest against placing a version number into the warning message. We've had
a few past examples when we did not follow up on deprecation warnings as promised.
> 
> Joshua Cohen wrote:
>     +1 to this.

Removed.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51506/#review147326
-----------------------------------------------------------


On Aug. 29, 2016, 5:37 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51506/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2016, 5:37 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
>     https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The flag is noted as deprecated for removal in 0.17.0.
> 
>  RELEASE-NOTES.md                                                                |  2
++
>  docs/reference/scheduler-configuration.md                                       |  4
++--
>  examples/vagrant/upstart/aurora-scheduler.conf                                  |  1
-
>  src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java | 11
+++++++++--
>  4 files changed, 13 insertions(+), 5 deletions(-)
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
>   docs/reference/scheduler-configuration.md c0c39442725c970e5f9811cd7b4ab3104364c671

>   examples/vagrant/upstart/aurora-scheduler.conf dd60981564286e5b25546737fdd0ce08b0168ed4

>   src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java 36ad18c49c5693031136440ab163070f9ffa9405

> 
> Diff: https://reviews.apache.org/r/51506/diff/
> 
> 
> Testing
> -------
> 
> Locally green:
> ```
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message