aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 51513: Add support for ETags in the Aurora API.
Date Tue, 30 Aug 2016 01:32:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51513/#review147255
-----------------------------------------------------------




src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java (lines 139 -
142)
<https://reviews.apache.org/r/51513/#comment214370>

    Am I reading this correctly: you're buffering the entire response in memory so we can
calculate the hash for the etag? Do you envision this causing memory pressure for larger responses
(especially given that the goal here is to optimize for the case where responses are large
enough that sending them on the wire and processing them on the client side is causing a perf
problem)?
    
    At the very least, perhaps we should only buffer the response if the `If-None-Match` header
is set?


- Joshua Cohen


On Aug. 30, 2016, 1:12 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51513/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2016, 1:12 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1757
>     https://issues.apache.org/jira/browse/AURORA-1757
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch enhances the Aurora API by producing an `ETag` header for each API
> request. It also consumes etag values in API requests via the `If-None-Match`
> header and produces a HTTP 304 if the request would produce a body with the same
> etag value.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
>   src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java 1634cb88ac09c778c5bb277ca902f4ca35dd6c9d

>   src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 0a3ff05586c87e0ab2cc20470e99b5dd609f7039

> 
> Diff: https://reviews.apache.org/r/51513/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message