aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.
Date Mon, 29 Aug 2016 20:32:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51502/#review147206
-----------------------------------------------------------



Master (874625e) is red with this patch.
  ./build-support/jenkins/build.sh

                         @mock.patch.dict(os.environ, {'MESOS_DIRECTORY': MOCK_MESOS_DIRECTORY})
                         def test_filesystem_sandbox_no_volumes(mock_safe_mkdir, mock_check_call):
                           sandbox_mount_point = '/some/mount/point'
                           sandbox_directory = os.path.join(MOCK_MESOS_DIRECTORY, 'sandbox'),
                         
                           sandbox = FileSystemImageSandbox(
                               sandbox_directory,
                               user='someuser',
                               no_create_user=True,
                               mounted_volume_paths=None,
                               sandbox_mount_point=sandbox_mount_point)
                         
                           sandbox._mount_paths()
                         
                           task_fs_path = os.path.join(MOCK_MESOS_DIRECTORY, 'taskfs')
                         
                     >     assert mock_check_call.mock_calls == [
                             mock.call([
                               'mount',
                               '--bind',
                               sandbox_directory,
                               os.path.join(task_fs_path, sandbox_mount_point[1:])
                             ])
                           ]
                     E     assert [call(['mount...ount/point'])] == [call(['mount'...ount/point'])]
                     E       At index 0 diff: call(['mount', '-n', '--rbind', ('/some/path/sandbox',),
'/some/path/taskfs/some/mount/point']) != call(['mount', '--bind', ('/some/path/sandbox',),
'/some/path/taskfs/some/mount/point'])
                     E       Full diff:
                     E       - [call(['mount', '-n', '--rbind', ('/some/path/sandbox',),
'/some/path/taskfs/some/mount/point'])]
                     E       ?                 ------   -
                     E       + [call(['mount', '--bind', ('/some/path/sandbox',),
'/some/path/taskfs/some/mount/point'])]
                     
                     src/test/python/apache/aurora/executor/common/test_sandbox.py:260: AssertionError
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

                      1 failed, 696 passed, 6 skipped, 1 warnings in 286.78 seconds

                     
FAILURE


20:32:15 05:07   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Aug. 29, 2016, 8:28 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51502/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2016, 8:28 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Clean up leaking of mounts into the host's mtab.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/sandbox.py cedcab68f31bb0a514ab42ccebc88ab2c7470d1c

>   src/test/python/apache/aurora/executor/common/test_sandbox.py 2ba3341273efe54d1a79fe48be50d4253530dcbc

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 7c32c94edf88d6dc0fbd7f838bea2b8077da0235

> 
> Diff: https://reviews.apache.org/r/51502/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh 
> e2e tests
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message