aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 51366: Unset PYTHONPATH before calling pants
Date Wed, 24 Aug 2016 14:06:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51366/#review146658
-----------------------------------------------------------


Ship it!




Ship It!

- Joshua Cohen


On Aug. 24, 2016, 12:07 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51366/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2016, 12:07 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Bugs: AURORA-1717
>     https://issues.apache.org/jira/browse/AURORA-1717
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Our tests are started via `./pants test.pytest` and are then calling `./pants binary`
within some test setup routines. Looks like that the `PYTHONPATH` can be tainted for the second
run. Unsetting it seems to prevent test failures of the kind:
> 
> ```
> Traceback (most recent call last):
> File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.80/bin/pants", line
7, in <module>
>  from pants.bin.pants_exe import main
> ImportError: No module named pants.bin.pants_exe
> ```
> 
> 
> Diffs
> -----
> 
>   pants b1ca3823b5b31cceccc5b9e4cb9a7ef79305d9fd 
> 
> Diff: https://reviews.apache.org/r/51366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message