aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 51264: Reduce static method exposure for Stats.
Date Sun, 21 Aug 2016 21:59:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51264/#review146273
-----------------------------------------------------------


Ship it!




Ship It!

- Stephan Erb


On Aug. 21, 2016, 3:28 vorm., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51264/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2016, 3:28 vorm.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> `org.apache.aurora.common.stats.Stats` has several static methods that are not used in
our codebase. This patch deletes the unused methods and reduces the visability of other static
methods where possible.
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java bb0af69a89e8f8905e7fd01183d0ac7fe2a49db2

> 
> Diff: https://reviews.apache.org/r/51264/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message