aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 51045: Remove unnecessary guice container parameters.
Date Fri, 12 Aug 2016 22:14:27 GMT


> On Aug. 12, 2016, 10:43 a.m., Bill Farner wrote:
> > Is there a downside to including this parameter?  The upside is expected behavior
of jaxb integration with jersey.  To be honest, I'm not sure how a bunch of endpoints continue
to work with this patch, as I believe several debugging endpoints rely on POJO mapping.

I'm not sure why things work either but with this patch the JAXRS endpoints work:
```
$ curl -s localhost:8081/tiers | python2.7 -mjson.tool
{
    "default": "preemptible",
    "tiers": {
        "preemptible": {
            "preemptible": true,
            "revocable": false
        },
        "preferred": {
            "preemptible": false,
            "revocable": false
        },
        "revocable": {
            "preemptible": true,
            "revocable": true
        }
    }
}
```

```
vagrant@aurora:~$ curl -s localhost:8081/offers | python2.7 -mjson.tool
[
    {
        "attributes": [],
        "executor_ids": [],
        "framework_id": {
            "value": "d7716da3-790d-4297-877b-93f724e91335-0000"
        },
        "hostname": "192.168.33.7",
        "id": {
            "value": "d7716da3-790d-4297-877b-93f724e91335-O0"
        },
        "resources": [
            {
                "name": "cpus",
                "role": "aurora-role",
                "scalar": {
                    "value": 0.5
                },
                "type": "SCALAR"
            },
            {
                "name": "mem",
                "role": "aurora-role",
                "scalar": {
                    "value": 1024.0
                },
                "type": "SCALAR"
            },
            {
                "name": "gpus",
                "role": "*",
                "scalar": {
                    "value": 4.0
                },
                "type": "SCALAR"
            },
            {
                "name": "cpus",
                "role": "*",
                "scalar": {
                    "value": 3.5
                },
                "type": "SCALAR"
            },
            {
                "name": "disk",
                "role": "*",
                "scalar": {
                    "value": 20000.0
                },
                "type": "SCALAR"
            },
            {
                "name": "ports",
                "ranges": {
                    "range": [
                        {
                            "begin": 31000,
                            "end": 32000
                        }
                    ]
                },
                "role": "*",
                "type": "RANGES"
            },
            {
                "name": "cpus",
                "revocable": {},
                "role": "*",
                "scalar": {
                    "value": 3.0
                },
                "type": "SCALAR"
            }
        ],
        "slave_id": {
            "value": "d7716da3-790d-4297-877b-93f724e91335-S0"
        },
        "url": {
            "address": {
                "hostname": "192.168.33.7",
                "ip": "192.168.33.7",
                "port": 5051
            },
            "path": "/slave(1)",
            "query": [],
            "scheme": "http"
        }
    }
]
```

I would like to remove it because it appears to do nothing and is confusing. If there is some
value gained, please let me know but as far as I can see this has no effect and should be
removed for clarity.

This is required for the /api endpoint to work AFAIK.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51045/#review145641
-----------------------------------------------------------


On Aug. 12, 2016, 10:23 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51045/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2016, 10:23 a.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The JSON/POJO mapping parameter is only required for the API servlet. The other servlets
do not need this configuration parameter.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 7bf8185695ab0af799ee297f39bcd79f6546cf6b

>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java e46820952fb6028911bca924169ceade6a134bfc

> 
> Diff: https://reviews.apache.org/r/51045/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message