aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 50931: Remove unnecessary guice container parameters.
Date Tue, 09 Aug 2016 20:34:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50931/#review145261
-----------------------------------------------------------



Master (581262c) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Aug. 9, 2016, 7:53 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50931/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2016, 7:53 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I noticed these configuration parameters have no effect. Both the API and JAX-RS endpoints
like /vars return gipped content.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 12185ec233ac8c9c6b974b60b7e102f48df61c55

> 
> Diff: https://reviews.apache.org/r/50931/diff/
> 
> 
> Testing
> -------
> 
> $ curl -I -X GET http://192.168.33.7:8081/vars -H 'Accept-Encoding: gzip, deflate'
> HTTP/1.1 200 OK
> Date: Mon, 08 Aug 2016 15:18:12 GMT
> Content-Type: text/plain
> Vary: Accept-Encoding, User-Agent
> Content-Encoding: gzip
> Transfer-Encoding: chunked
> Server: Jetty(9.3.6.v20151106)
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message