aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 50931: Remove unnecessary guice container parameters.
Date Tue, 09 Aug 2016 20:19:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50931/#review145256
-----------------------------------------------------------



Master (581262c) is red with this patch.
  ./build-support/jenkins/build.sh

                           proxy_driver = ProxyDriver()
                           with temporary_dir() as checkpoint_root:
                             te = AuroraExecutor(
                     >           runner_provider=make_provider(checkpoint_root),
                                 sandbox_provider=DefaultTestSandboxProvider())
                     
                     src/test/python/apache/aurora/executor/test_thermos_executor.py:580:

                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     src/test/python/apache/aurora/executor/test_thermos_executor.py:193:
in make_provider
                         pex_location=thermos_runner_path(),
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     build = True
                     
                         def thermos_runner_path(build=True):
                           if not build:
                             return getattr(thermos_runner_path, 'value', None)
                         
                           if not hasattr(thermos_runner_path, 'value'):
                             pex_dir = safe_mkdtemp()
                     >       assert subprocess.call(["./pants", "--pants-distdir=%s"
% pex_dir, "binary",
                               "src/main/python/apache/thermos/runner:thermos_runner"])
== 0
                     E       assert 1 == 0
                     E        +  where 1 = <function call at 0x7ff8f94ea9b0>(['./pants',
'--pants-distdir=/tmp/tmpegMEOQ', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])
                     E        +    where <function call at 0x7ff8f94ea9b0>
= subprocess.call
                     
                     src/test/python/apache/aurora/executor/test_thermos_executor.py:185:
AssertionError
                     -------------- Captured stderr call --------------
                     Traceback (most recent call last):
                       File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/bin/pants",
line 7, in <module>
                         from pants.bin.pants_exe import main
                     ImportError: No module named pants.bin.pants_exe
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

                      16 failed, 661 passed, 6 skipped, 1 warnings, 8 error in 149.39
seconds 
                     
FAILURE


20:19:17 02:53   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Aug. 9, 2016, 7:53 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50931/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2016, 7:53 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I noticed these configuration parameters have no effect. Both the API and JAX-RS endpoints
like /vars return gipped content.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 12185ec233ac8c9c6b974b60b7e102f48df61c55

> 
> Diff: https://reviews.apache.org/r/50931/diff/
> 
> 
> Testing
> -------
> 
> $ curl -I -X GET http://192.168.33.7:8081/vars -H 'Accept-Encoding: gzip, deflate'
> HTTP/1.1 200 OK
> Date: Mon, 08 Aug 2016 15:18:12 GMT
> Content-Type: text/plain
> Vary: Accept-Encoding, User-Agent
> Content-Encoding: gzip
> Transfer-Encoding: chunked
> Server: Jetty(9.3.6.v20151106)
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message