aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Shirchenko <cald...@gmail.com>
Subject Re: Review Request 50826: Populate the source field of ExecutorInfo.
Date Fri, 05 Aug 2016 00:36:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50826/#review144853
-----------------------------------------------------------


Ship it!




plz add a test and then LGTM

- Dmitriy Shirchenko


On Aug. 5, 2016, 12:34 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50826/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2016, 12:34 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Dmitriy Shirchenko.
> 
> 
> Bugs: AURORA-1745
>     https://issues.apache.org/jira/browse/AURORA-1745
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> b912e17 stopped populating the source field of the executor. For backwards compatibility
we should continue to populate this field and the `source` label.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 34134430063b2d24a4e20d3f91ab899604edaf89

> 
> Diff: https://reviews.apache.org/r/50826/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message