aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kunal Thakar <kun...@gmail.com>
Subject Re: Review Request 50685: Support TBinaryProtocol over HTTP
Date Thu, 04 Aug 2016 18:00:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50685/#review144797
-----------------------------------------------------------




RELEASE-NOTES.md (line 20)
<https://reviews.apache.org/r/50685/#comment210905>

    s/with/without


- Kunal Thakar


On Aug. 3, 2016, 10:29 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50685/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2016, 10:29 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Dmitriy Shirchenko, and Stephan Erb.
> 
> 
> Bugs: AURORA-1743
>     https://issues.apache.org/jira/browse/AURORA-1743
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This replaces the `TServlet` servlet from thrift with our own servlet which dispatches
thrift responses based on the content type of the request. This enables a client to use either
the thrift json protocol or the binary protocol when communicating with the scheduler.
> 
> Without this patch the current behaviour is:
> - Regardless of content type of the request, assume the request is json and return json
with a `application/x-thrift` content type.
> 
> With this patch the behaviour becomes:
> - A request with no content type header, or a type of `application/x-thrift` or `application/json`
or `application/vnd.apache.thrift.json` is assumed to be JSON.
> - A request with a content type header of `application/vnd.apache.thrift.binary` is assumed
to be binary.
> - A request with an `Accept` header of `application/vnd.apache.thrift.binary` will have
a binary response.
> - A request with any other `Accept` header will have a JSON response.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 19d7f7e34652d170a7d8eb41a9c6ffdcc67324eb 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java cd5adf9655dc3368dbe06bfee15c65182176be2e

>   src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 7dbe48b433262a5b9f7b369d69a0d41e2472b054

>   src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 31f5cb3bed48eef60c3b2becb2ed285e93f2bd5a

> 
> Diff: https://reviews.apache.org/r/50685/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message