aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <ma...@apache.org>
Subject Re: Review Request 50168: Add rollback functionality to the scheduler
Date Tue, 02 Aug 2016 23:21:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50168/#review144552
-----------------------------------------------------------



LGTM overall. Only some polishing left.


CHANGELOG (line 4)
<https://reviews.apache.org/r/50168/#comment210572>

    Not yours but mind removing trailing space since your are here?



api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 1109)
<https://reviews.apache.org/r/50168/#comment210577>

    s/job update/active job update



api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 1112)
<https://reviews.apache.org/r/50168/#comment210578>

    s/pause/rollback



api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 1117)
<https://reviews.apache.org/r/50168/#comment210585>

    remove extra newline



api/src/main/thrift/org/apache/aurora/gen/storage.thrift (lines 95 - 99)
<https://reviews.apache.org/r/50168/#comment210575>

    This is no longer needed.



src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java (line 126)
<https://reviews.apache.org/r/50168/#comment210580>

    This should be reworded to clearly state only active updates are supported.



src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java (line 131)
<https://reviews.apache.org/r/50168/#comment210581>

    Same here.



src/main/python/apache/aurora/client/cli/update.py (line 90)
<https://reviews.apache.org/r/50168/#comment210590>

    Since this only triggers the rollback and does not wait until rollback finishes, I suggest
rephrasing it to something like:"Update rollback has started" or maybe even: "Update rollback
has started. View your update progress at %s"
    
    Would also be great to support `WAIT_OPTION` here similar to `StartUpdate`.



src/main/python/apache/aurora/client/cli/update.py (lines 113 - 114)
<https://reviews.apache.org/r/50168/#comment210588>

    Remove leftover method?



src/main/python/apache/aurora/client/cli/update.py (line 324)
<https://reviews.apache.org/r/50168/#comment210592>

    Please, add coverage to test_supdate.py.



src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java (lines 1514 - 1515)
<https://reviews.apache.org/r/50168/#comment210591>

    Is this used anywhere apart from overloaded method?


- Maxim Khutornenko


On Aug. 2, 2016, 9:20 p.m., Igor Morozov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50168/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 9:20 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1721
>     https://issues.apache.org/jira/browse/AURORA-1721
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add rollback functionality to the scheduler
> 
> Thic change also includes an addition to storage replicated log. I needed a way to re-insert
lock token for an existing job update.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG fc6a46d77ebf889c8f60402c95e8a7472980ba1c 
>   RELEASE-NOTES.md 19d7f7e34652d170a7d8eb41a9c6ffdcc67324eb 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 1d66208490aff6ea8af4c737845fa2cf13617529

>   api/src/main/thrift/org/apache/aurora/gen/storage.thrift 9e4213f13255a182df938bea44ca87fa03a25318

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java b534abf95bab6e1657e3ef993cf34c0d6ec460be

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 9243c92b11040b68ed6014b3991db69fc08bcddf

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java f8357c46df1b025bf4e38a7ce1cb1c13a50c39f9

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 364c5c753f884a2d89e27802d7bbf3b2b6d3a08e

>   src/main/python/apache/aurora/client/api/__init__.py ec2c786d143347a7953f9fe431c6ddc59e1b9854

>   src/main/python/apache/aurora/client/cli/update.py bb526f7bf94d7bfe02fe2786493c85be1bfeb86f

>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java e157c0dfde5efc418448e138aa008ade742fe816

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py afbd385b7eda64cb1f7d118b695e65e4045eac6c

> 
> Diff: https://reviews.apache.org/r/50168/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Igor Morozov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message