aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710
Date Tue, 26 Jul 2016 15:45:40 GMT


> On July 26, 2016, 2:36 p.m., Joshua Cohen wrote:
> > I know this is already landed, but it would be nice to follow this up with a test
case if possible?
> 
> Mehrdad Nurolahzade wrote:
>     The logic has two test cases: (https://github.com/apache/aurora/blob/380307ac1878cb71bc86d2ccd7887192161254cf/src/test/python/apache/aurora/client/test_config.py#L228-L243).

Yes, but they weren't failing though? It seems they were not sufficient to catch this problem.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50432/#review143525
-----------------------------------------------------------


On July 26, 2016, 2:36 a.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50432/
> -----------------------------------------------------------
> 
> (Updated July 26, 2016, 2:36 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1741
>     https://issues.apache.org/jira/browse/AURORA-1741
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/config.py 96cd9ddf77cac449d68537cd652bca03ef87d75d

> 
> Diff: https://reviews.apache.org/r/50432/diff/
> 
> 
> Testing
> -------
> 
> ```
> ./build-support/jenkins/build.sh
> 
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message