aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Shirchenko <cald...@gmail.com>
Subject Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint
Date Tue, 19 Jul 2016 21:13:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50052/#review142830
-----------------------------------------------------------




File Attachment: NEW - offers-new.json
<https://reviews.apache.org//r/50052/#fcomment102>

    Why is there a double nested labels: labels array under reservation? Is this just a carry
over from how Aurora gets offers from Mesos?
    
    So there is a key `labels` and then underneath is there's another key `labels` whose value
is an array. Seems like one of them is not necessary.
    
    ```json
    reservation: {
    labels: {
    labels: [
    {
    key: "job",
    value: "devcluster/www-data/prod/hello"
    }
    ]
    }
    }
    ```


- Dmitriy Shirchenko


On July 19, 2016, 2:12 a.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50052/
> -----------------------------------------------------------
> 
> (Updated July 19, 2016, 2:12 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1736
>     https://issues.apache.org/jira/browse/AURORA-1736
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint
> 
> 
> Diffs
> -----
> 
>   config/legacy_untested_classes.txt 1ea2183ab20cc5c6bca147bcea4e5c708d576b62 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 80f082410896a50d86c7886736caf79581f5051c

>   src/test/java/org/apache/aurora/scheduler/http/OffersTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50052/diff/
> 
> 
> Testing
> -------
> 
> Manual, Jenkins, and end_to_end
> 
> 
> File Attachments
> ----------------
> 
> CURRENT
>   https://reviews.apache.org/media/uploaded/files/2016/07/18/1de4c357-c932-4c84-962f-4209a5b679bc__offers-old.json
> NEW
>   https://reviews.apache.org/media/uploaded/files/2016/07/19/799bcd1f-f9c8-4b6e-bbaa-ce8022b1dac1__offers-new.json
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message