aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 49868: Update virtualenv version to 15.0.2
Date Sun, 10 Jul 2016 18:15:44 GMT


> On July 10, 2016, 7:55 p.m., Aurora ReviewBot wrote:
> > Master (528198e) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >                            with temporary_dir() as checkpoint_root:
> >                              te = AuroraExecutor(
> >                      >           runner_provider=make_provider(checkpoint_root),
> >                                  sandbox_provider=DefaultTestSandboxProvider())
> >                      
> >                      src/test/python/apache/aurora/executor/test_thermos_executor.py:580:

> >                      _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> >                      src/test/python/apache/aurora/executor/test_thermos_executor.py:193:
in make_provider
> >                          pex_location=thermos_runner_path(),
> >                      _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> >                      
> >                      build = True
> >                      
> >                          def thermos_runner_path(build=True):
> >                            if not build:
> >                              return getattr(thermos_runner_path, 'value', None)
> >                          
> >                            if not hasattr(thermos_runner_path, 'value'):
> >                              pex_dir = safe_mkdtemp()
> >                      >       assert subprocess.call(["./pants", "--pants-distdir=%s"
% pex_dir, "binary",
> >                                "src/main/python/apache/thermos/runner:thermos_runner"])
== 0
> >                      E       assert 1 == 0
> >                      E        +  where 1 = <function call at 0x7f55080b99b0>(['./pants',
'--pants-distdir=/tmp/user/10021/tmpkeKy3H', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])
> >                      E        +    where <function call at 0x7f55080b99b0>
= subprocess.call
> >                      
> >                      src/test/python/apache/aurora/executor/test_thermos_executor.py:185:
AssertionError
> >                      -------------- Captured stderr call --------------
> >                      Traceback (most recent call last):
> >                        File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-pre6/bin/pants",
line 7, in <module>
> >                          from pants.bin.pants_exe import main
> >                      ImportError: No module named pants.bin.pants_exe
> >                       generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

> >                       16 failed, 652 passed, 6 skipped, 1 warnings, 8 error
in 169.95 seconds 
> >                      
> > FAILURE
> > 
> > 
> >                Waiting for background workers to finish.
> > 17:55:29 03:42   [complete]
> >                FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"

It looks like as if those tests are failing which are calling `./pants` from within the test
code.


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49868/#review141619
-----------------------------------------------------------


On July 10, 2016, 7:38 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49868/
> -----------------------------------------------------------
> 
> (Updated July 10, 2016, 7:38 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Bugs: AURORA-1717
>     https://issues.apache.org/jira/browse/AURORA-1717
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Update virtualenv to 15.0.2. This includes updates to `pip==8.1.2`, `setuptools==21.2.1`,
and `wheel==0.29.0`. Full changelog: https://virtualenv.pypa.io/en/stable/changes/
> 
> Additional changes to our scripts:
> 
> * abort the pants bootstrapping script if an error is encountered
> * switch to download URLs that are working for the latest virtualenv version
> * disable the recently added auto-updating of pip and setuptools so that we gain a reproducable
build environment
> 
> 
> Diffs
> -----
> 
>   build-support/virtualenv 03c14323e14d2a3923e080efc947107b9b8a3a16 
>   pants a11588a02d9b471b600a5095476caa5ae8eb8161 
> 
> Diff: https://reviews.apache.org/r/49868/diff/
> 
> 
> Testing
> -------
> 
> rm -rf ~/.cache/pants/
> git clean -fxd
> ./pants test.pytest src/{main,test}/python::
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message