aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 49528: Patch thrift to compile under modern gcc.
Date Mon, 04 Jul 2016 15:36:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49528/#review140671
-----------------------------------------------------------




build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch (line
8)
<https://reviews.apache.org/r/49528/#comment206032>

    This is a bug - should be `if (!first) {`.  We don't hit this bug since we don't declare
thrift service exceptions, but I'll circle back with a fix for sanity sake.


- John Sirois


On July 1, 2016, 1:28 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49528/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 1:28 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1727
>     https://issues.apache.org/jira/browse/AURORA-1727
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This also patches the thrift compiler Makefile.in to eliminate all
> generators not used by Aurora to both work around their modern gcc
> compiler errors and speed up the thrift compiler build.
> 
>  build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch                    
 | 376 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
|  14 ++
>  build-support/thrift/Makefile                                                      
 |   2 +
>  3 files changed, 392 insertions(+)
> 
> 
> Diffs
> -----
> 
>   build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch PRE-CREATION 
>   build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
PRE-CREATION 
>   build-support/thrift/Makefile c28f4146b4874fe5faf6dbd872a692d39816d4bb 
> 
> Diff: https://reviews.apache.org/r/49528/diff/
> 
> 
> Testing
> -------
> 
> Locally green under gcc 6.1.1 20160602 using:
> ```
> git clean -fdx build-support/thrift/
> ./gradlew -Pq clean build
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message