aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 49512: [FEEDBACK] Add thermos option to monitor whole docker storage disk usage
Date Mon, 04 Jul 2016 07:55:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49512/#review140619
-----------------------------------------------------------



Have you considered querying Mesos for the disk usage of the task? That would be in line with
our desire to also leave the isolation up to Mesos https://issues.apache.org/jira/browse/AURORA-1033

- Stephan Erb


On July 1, 2016, 4:51 p.m., Martin Hrabovcin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49512/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 4:51 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I'd like to get feedback on this patch.
> 
> Thermos currently monitors only sandbox directory but when running with Docker containerizer
process can write data to whole container filesystem. This patch gives option to monitor whole
docker container filesystem.
> 
> Behavior is unchanged if new flag isn't provided.
> 
> 
> Diffs
> -----
> 
>   examples/jobs/docker/hello_docker.aurora 47adb3932323120e62649f43353719b76c48a963 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 203fc47d74840889a1192dc867fef5584b704685

>   src/main/python/apache/aurora/executor/common/resource_manager.py b7dc40d8973ec2e5998ab4f6ff988051a70bb1ab

>   src/main/python/apache/thermos/monitoring/disk.py 52c5d74fd70b5942ea3ef5101ba3f27bfc98fc21

>   src/main/python/apache/thermos/monitoring/resource.py 53d0ff1a71c27f053c59acca556c35d1e5ac91f0

>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
fe74bd1d36666ecd89fca1b5b2251202cbbc0f24 
>   src/test/python/apache/thermos/monitoring/test_disk.py e57467c61d94d67e6cf6b766c062588235b4b235

> 
> Diff: https://reviews.apache.org/r/49512/diff/
> 
> 
> Testing
> -------
> 
> e2e testing
> unit tests
> manual testing in Vagrant dev box and on custom dev cluster with option enabled.
> 
> 
> Thanks,
> 
> Martin Hrabovcin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message