aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Review Request 49527: Reduce log level of finding a valid leader
Date Fri, 01 Jul 2016 19:29:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49527/
-----------------------------------------------------------

Review request for Aurora and John Sirois.


Repository: aurora


Description
-------

Since the introduction of the Curator-backend [1], we have been logging the currently active
leader on each request. This happens even if the queried scheduler is also the leading one.
By reducing the log level to debug, we can reduce the logging noise of Aurora significantly.

```
I0630 11:38:04.871 [qtp806277656-123, Slf4jRequestLog:60] 10.x.x.x - - [30/Jun/2016:11:38:04
+0000] "POST //master1.example.org/api HTTP/1.1" 307 0
I0630 11:38:04.879 [qtp806277656-129, LeaderRedirect:197] Found leader scheduler at [ServiceInstance(serviceEndpoint:Endpoint(host:master2.example.org,
port:8081), additionalEndpoints:{http=Endpoint(host:master2.example.org port:8081)}, status:ALIVE)]
I0630 11:38:04.879 [qtp806277656-129, LeaderRedirect:197] Found leader scheduler at [ServiceInstance(serviceEndpoint:Endpoint(host:master2.example.org,
port:8081), additionalEndpoints:{http=Endpoint(host:master2.example.org, port:8081)}, status:ALIVE)]
I0630 11:38:04.880 [qtp806277656-129, LeaderRedirect:197] Found leader scheduler at [ServiceInstance(serviceEndpoint:Endpoint(host:master2.example.org,
port:8081), additionalEndpoints:{http=Endpoint(host:master2.example.org, port:8081)}, status:ALIVE)]
```

[1] https://github.com/apache/aurora/commit/103dae6871eaa76914ab7fe17adaa174e93f537a#diff-1a20d033e88f293107537e09636007ffR190


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 3847fb86be5fe631466d114eb8b1f07b54f2a549


Diff: https://reviews.apache.org/r/49527/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Stephan Erb


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message