aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mehrdad Nurolahzade <mehr...@nurolahzade.com>
Subject Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes
Date Tue, 21 Jun 2016 23:09:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/
-----------------------------------------------------------

(Updated June 21, 2016, 4:09 p.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Repository: aurora


Description
-------

AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration
- CLI changes


Diffs
-----

  src/main/python/apache/aurora/client/api/__init__.py 68baf8fdb90cd26100159401c46c9963c24332b3

  src/main/python/apache/aurora/config/__init__.py 65923be1cb8b88139b8eab0ac5b75428972d3cb1

  src/main/python/apache/aurora/config/thrift.py 3539469d243638c0acd08bf0859d0ce858d8977c

  src/test/python/apache/aurora/client/cli/test_command_hooks.py 2130f1fa71be02a004cdf8e476a270c81a7105d3

  src/test/python/apache/aurora/client/cli/test_create.py 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c

  src/test/python/apache/aurora/client/cli/test_cron.py f3c522ed94a2d774865811ceb546bf9df083c14f

  src/test/python/apache/aurora/client/cli/test_inspect.py fedc16b3d4e9fb7d6f5f0dc34ad7a1837e34baea

  src/test/python/apache/aurora/client/cli/test_plugins.py a545fece5e2b3e0017a61e1be9ac478372b1f34d

  src/test/python/apache/aurora/client/cli/test_restart.py 967d560e5c7eb0ed85b215fb11d9751b8666acb5

  src/test/python/apache/aurora/client/cli/util.py 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e

  src/test/python/apache/aurora/client/test_config.py b1a3c1865819899ef19173be0f861783a2631d0a

  src/test/python/apache/aurora/config/__init__.py PRE-CREATION 
  src/test/python/apache/aurora/config/test_base.py b354f0804ce70682e8ecb9fb3a3d8fe736fd1cc5

  src/test/python/apache/aurora/config/test_thrift.py e213184739167e01f3614c20a809af39b3a6b3d6


Diff: https://reviews.apache.org/r/49048/diff/


Testing (updated)
-------

Solution fails end to end test, this is WIP intended to receive feedback

I seem to have introduced a dependency between thermos executor and client api that is causing
the executor fail with the following sample error log:
```
cat /var/lib/mesos/slaves/c8fd5700-d2ad-4249-b705-94d40451681b-S0/frameworks/c8fd5700-d2ad-4249-b705-94d40451681b-0001/executors/thermos-www-data-prod-hello-0-f4543715-21f2-402c-9a75-656cb90693b8/runs/19621370-6b72-4c9e-8569-d11c6ca67456/stderr

I0621 21:29:00.888162 23895 fetcher.cpp:424] Fetcher Info: {"cache_directory":"\/tmp\/mesos\/fetch\/slaves\/c8fd5700-d2ad-4249-b705-94d40451681b-S0\/root","items":[{"action":"BYPASS_CACHE","uri":{"executable":true,"extract":true,"value":"\/home\/vagrant\/aurora\/dist\/thermos_executor.pex"}}],"sandbox_directory":"\/var\/lib\/mesos\/slaves\/c8fd5700-d2ad-4249-b705-94d40451681b-S0\/frameworks\/c8fd5700-d2ad-4249-b705-94d40451681b-0001\/executors\/thermos-www-data-prod-hello-0-f4543715-21f2-402c-9a75-656cb90693b8\/runs\/19621370-6b72-4c9e-8569-d11c6ca67456","user":"root"}
I0621 21:29:00.889114 23895 fetcher.cpp:379] Fetching URI '/home/vagrant/aurora/dist/thermos_executor.pex'
I0621 21:29:00.889127 23895 fetcher.cpp:250] Fetching directly into the sandbox directory
I0621 21:29:00.889137 23895 fetcher.cpp:187] Fetching URI '/home/vagrant/aurora/dist/thermos_executor.pex'
I0621 21:29:00.889147 23895 fetcher.cpp:167] Copying resource with command:cp '/home/vagrant/aurora/dist/thermos_executor.pex'
'/var/lib/mesos/slaves/c8fd5700-d2ad-4249-b705-94d40451681b-S0/frameworks/c8fd5700-d2ad-4249-b705-94d40451681b-0001/executors/thermos-www-data-prod-hello-0-f4543715-21f2-402c-9a75-656cb90693b8/runs/19621370-6b72-4c9e-8569-d11c6ca67456/thermos_executor.pex'
I0621 21:29:00.913426 23895 fetcher.cpp:456] Fetched '/home/vagrant/aurora/dist/thermos_executor.pex'
to '/var/lib/mesos/slaves/c8fd5700-d2ad-4249-b705-94d40451681b-S0/frameworks/c8fd5700-d2ad-4249-b705-94d40451681b-0001/executors/thermos-www-data-prod-hello-0-f4543715-21f2-402c-9a75-656cb90693b8/runs/19621370-6b72-4c9e-8569-d11c6ca67456/thermos_executor.pex'
+ /usr/libexec/mesos/mesos-containerizer mount --help=false --operation=make-rslave --path=/
+ grep -E /var/lib/mesos/.+ /proc/self/mountinfo
+ cut -d  -f5
+ xargs --no-run-if-empty umount -l
+ grep -v 19621370-6b72-4c9e-8569-d11c6ca67456
Traceback (most recent call last):
  File ".bootstrap/_pex/pex.py", line 324, in execute
  File ".bootstrap/_pex/pex.py", line 257, in _wrap_coverage
  File ".bootstrap/_pex/pex.py", line 289, in _wrap_profiling
  File ".bootstrap/_pex/pex.py", line 367, in _execute
  File ".bootstrap/_pex/pex.py", line 425, in execute_entry
  File ".bootstrap/_pex/pex.py", line 442, in execute_pkg_resources
  File ".bootstrap/pkg_resources.py", line 2190, in load
  File "apache/aurora/executor/bin/thermos_executor_main.py", line 31, in <module>
  File "apache/aurora/config/__init__.py", line 28, in <module>
  File "apache/aurora/config/thrift.py", line 21, in <module>
ImportError: No module named client.api
```

Not sure if this is the right way to go, please advise. 
The error obviously goes away by adding ```src/main/python/apache/aurora/client``` to executor
pants BUILD file. But, 'is that OK if I introduce this dependency?' is what I am asking.


Thanks,

Mehrdad Nurolahzade


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message