aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 48606: Improve consistency of the RPM and DEB default configuration
Date Wed, 15 Jun 2016 21:49:32 GMT


> On June 13, 2016, 12:14 a.m., Stephan Erb wrote:
> > specs/rpm/SOURCES/aurora-scheduler.sysconfig, lines 33-36
> > <https://reviews.apache.org/r/48606/diff/1/?file=1416269#file1416269line33>
> >
> >     Should we adopt the same configuration schema also for Debian and Ubuntu?
> >     
> >     Using a Bash array is easier and more flexible than the list of environment
variables that is currently used by the DEB packages.
> >     
> >     What do you think?
> 
> Benjamin Staffin wrote:
>     I'm a fan.  That usually makes things easier to deal with in config management systems,
too.  Just make sure that it's safe to assume that the shell processing it is bash on the
debian/ubuntu side.

Unfortunately, I have to shelf this for now. The `/bin/bash` vs `/bin/sh`(dash) problem is
easy to workaround in Debian but kind of problematic in the Ubuntu upstart scripts. 

I still like the idea and might pick it up one day again. However, I don't want to block progress
on the package releases.


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48606/#review137203
-----------------------------------------------------------


On June 15, 2016, 11:46 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48606/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 11:46 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, Jake Farrell, and Kasisnu Singh.
> 
> 
> Bugs: AURORA-1394
>     https://issues.apache.org/jira/browse/AURORA-1394
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> * Use identical scheduler default arguments
> * Log to stderr rather than disk in all packages
> * Use vagrant as the example role. It is available for all distributions
> * Use the same clusters.json for all distributions
> * Rename the clutername from main to example
> 
> 
> Diffs
> -----
> 
>   specs/debian/aurora-executor.thermos.init 9bc8675952bb21474617e99374fa20c452085fa6

>   specs/debian/aurora-scheduler.default 71d1625b5c2fbe17f68731c120e1c354c96c75d5 
>   specs/debian/clusters.json 29c2e0b61c6a2e945152ea3a39cee883696de2c1 
>   specs/rpm/SOURCES/aurora-scheduler.sysconfig d812341cc44e1ae086132deb117e89ad92f3228b

>   specs/rpm/SOURCES/clusters.json 133013ba2ede037eb5c5e8e9255e6391cddf0d40 
>   test/deb/debian-jessie/README.md b84ffd9b92910c7cd1bc014f12a14a39857b4af9 
>   test/deb/ubuntu-trusty/README.md bb793410f1bb2bbb1231eb3ca0ad7f7d8ba14fc0 
>   test/rpm/centos-7/README.md bb34fb6b5dad0971226b4a9adb89d69e85c633a4 
> 
> Diff: https://reviews.apache.org/r/48606/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message