aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Renan DelValle <rdelv...@binghamton.edu>
Subject Re: Review Request 48360: Updated documentation to include custom executor explaination
Date Tue, 07 Jun 2016 21:59:58 GMT


> On June 7, 2016, 9:41 p.m., Joshua Cohen wrote:
> > docs/operations/configuration.md, lines 154-162
> > <https://reviews.apache.org/r/48360/diff/1/?file=1410557#file1410557line154>
> >
> >     Rather than explaining this in conversational English, it might be easier to
understand if we just have a table that lists the allowed attributes for each property in
the config file?
> >     
> >     Something like...
> >     
> >       ### command
> >     
> >       **Property**             | **Description**
> >       -------------------      | ---------------------------------
> >       **value** (required)     | The command to execute.
> >       **arguments** (optional) | A list of arguments to pass to the command.
> >       **uris** (optional)      | Resources to download into the task sandbox.
> >       
> >       ### volume_mounts
> >       ...
> >     
> >     What do you think?

Awesome idea, I'll have a revisision of this including this in a little bit. Fixed everything
else that you mentioned. Thanks for the speedy review!


- Renan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48360/#review136552
-----------------------------------------------------------


On June 7, 2016, 9 p.m., Renan DelValle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48360/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 9 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding documentation for using a custom executor configuration.
> 
> 
> Diffs
> -----
> 
>   docs/operations/configuration.md 65cf64a713db87996b92bf8305d1fc565163f106 
> 
> Diff: https://reviews.apache.org/r/48360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message