aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <ma...@apache.org>
Subject Re: Review Request 47998: Converting resource counters to use new resource fields
Date Tue, 07 Jun 2016 21:01:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47998/
-----------------------------------------------------------

(Updated June 7, 2016, 9:01 p.m.)


Review request for Aurora, Joshua Cohen and Stephan Erb.


Changes
-------

Rebased.


Repository: aurora


Description
-------

The side-effect of this refactoring is converting from GB to MB in RAM/Disk metrics. This
is consistent with the rest of the system and does not require an additional complexity of
some sort of a unit converter in `ResourceType`. All scheduler consumed resources stats will
change as:
_cpu -> _cpu_cores
_ram_gb -> _ram_mb
_disk_gb -> _disk_gb


Diffs (updated)
-----

  RELEASE-NOTES.md 741c725bc33b5ba575aed3351a023ed00633c500 
  src/main/java/org/apache/aurora/scheduler/http/Utilization.java 4a609e368a451f3f3b0b0fde9770aed213325f0d

  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 612525c32654c60962a0319a66905c325a0d5a1c

  src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java bfe75839785da6f763cf72a7341c1dedec0b2745

  src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 5231e9f547004534c027289111544e707a64e6ec

  src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java 2511a39fecadc775aee574515f52ac49ba137855

  src/main/resources/org/apache/aurora/scheduler/http/utilization.st acb8f46a3e830f85338b8cb44e7ad046afce5786

  src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeTest.java 7ba5567910c46127dab546ad3ad3bb70f562ec2b

  src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java fd4b434aef9d18c94eac51c6ea58512df1f07346


Diff: https://reviews.apache.org/r/47998/diff/


Testing
-------


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message