aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mehrdad Nurolahzade <mehr...@nurolahzade.com>
Subject Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration
Date Mon, 06 Jun 2016 19:13:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48082/
-----------------------------------------------------------

(Updated June 6, 2016, 7:13 p.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Changes
-------

(1) Applied suggested refactorings
(2) Raised AURORA-1708 for deprecation of 'production' flag


Repository: aurora


Description
-------

AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration
- New thrift API for retrieving tier configuration


Diffs (updated)
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift ed94f249d85ac0e438213924c777cf7c029a119a

  src/main/java/org/apache/aurora/scheduler/TierManager.java b96189be0ada1623665c2bff2550c1d72d7bc3dd

  src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java e431b58c933886f46c095240704d3eb0ceea2d80

  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 0d4f04403ec20c21b7cfacd706557cd191579f0a

  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 4d032b96d55dd0b92fab338220e66628e38cbb11

  src/main/resources/org/apache/aurora/scheduler/tiers.json f724c5ad03a1315bc55dac35d98fdef45625e017

  src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 95174bb7454a9e7c075ebaa6a4f84bf55fbc2652

  src/test/java/org/apache/aurora/scheduler/TierModuleTest.java 6b4e7a0d5e64d0632c66273ad516f737b2ef4a92

  src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 2122f744089adaee24328a634a2f786d1ef9720f


Diff: https://reviews.apache.org/r/48082/diff/


Testing
-------

Manual/Explorative: Invoked from CLI-side to see if the new API call works as intended
Integration: ./build-support/jenkins/build.sh
E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Mehrdad Nurolahzade


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message