aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 47998: Converting resource counters to use new resource fields
Date Sat, 28 May 2016 21:35:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47998/#review135394
-----------------------------------------------------------


Fix it, then Ship it!




The refactoring itself looks good. However, I am not sure if we should really opt for the
metric name change. It will break external statistic scrapers without a great benefit for
us.


src/main/java/org/apache/aurora/scheduler/http/Utilization.java (lines 126 - 136)
<https://reviews.apache.org/r/47998/#comment200408>

    I am confused. Where are those used?



src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java (lines 43 - 49)
<https://reviews.apache.org/r/47998/#comment200410>

    If you decide to stick to the new names, please mention the change in the release notes.


- Stephan Erb


On May 28, 2016, 2:43 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47998/
> -----------------------------------------------------------
> 
> (Updated May 28, 2016, 2:43 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The side-effect of this refactoring is converting from GB to MB in RAM/Disk metrics.
This is consistent with the rest of the system and does not require an additional complexity
of some sort of a unit converter in `ResourceType`. All scheduler consumed resources stats
will change as:
> _cpu -> _cpu_cores
> _ram_gb -> _ram_mb
> _disk_gb -> _disk_gb
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/Utilization.java 4a609e368a451f3f3b0b0fde9770aed213325f0d

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 612525c32654c60962a0319a66905c325a0d5a1c

>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 6a4f110ff461876ca14c24947f4813d5f2a0dae5

>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 5231e9f547004534c027289111544e707a64e6ec

>   src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java 2511a39fecadc775aee574515f52ac49ba137855

>   src/main/resources/org/apache/aurora/scheduler/http/utilization.st ae497a7c2b5c76a74e5b7ed07b98286a2542aa12

>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeTest.java 7ba5567910c46127dab546ad3ad3bb70f562ec2b

>   src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java fd4b434aef9d18c94eac51c6ea58512df1f07346

> 
> Diff: https://reviews.apache.org/r/47998/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message