aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <ma...@apache.org>
Subject Review Request 47846: Removing requestedPorts usage from the UI
Date Wed, 25 May 2016 19:30:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47846/
-----------------------------------------------------------

Review request for Aurora and Joshua Cohen.


Repository: aurora


Description
-------

It completely escaped my attention that `requestedPorts` is also a deprecated field and as
such should be purged from the UI.

Added `PORTS` support and converted resource filter to work with multiple resource values
to account for ports.

Also, renamed filter "enum" fields to match scheduler and client definitions.


Diffs
-----

  src/main/resources/scheduler/assets/configSummary.html 97104def4b9ef65fa2be97db3a8312e4afc7d18d

  src/main/resources/scheduler/assets/js/controllers.js 2131c42f96322f8220d69098d5bcb4a516af0437

  src/main/resources/scheduler/assets/js/filters.js 34fc18587fc23bd8166d621db808fb477a445f50

  src/main/resources/scheduler/assets/js/services.js a633396185c84e9ee75ce6b17a76ee8017be4cfe


Diff: https://reviews.apache.org/r/47846/diff/


Testing
-------

tested in vagrant


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message