aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Shirchenko <cald...@gmail.com>
Subject Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint
Date Wed, 25 May 2016 01:02:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47440/#review134637
-----------------------------------------------------------




docs/reference/scheduler-configuration.md (line 222)
<https://reviews.apache.org/r/47440/#comment199490>

    Done.



src/main/java/org/apache/aurora/scheduler/events/Webhook.java (line 42)
<https://reviews.apache.org/r/47440/#comment199500>

    Done.



src/main/java/org/apache/aurora/scheduler/events/Webhook.java (line 46)
<https://reviews.apache.org/r/47440/#comment199479>

    Done.



src/main/java/org/apache/aurora/scheduler/events/Webhook.java (lines 54 - 55)
<https://reviews.apache.org/r/47440/#comment199480>

    Done.



src/main/java/org/apache/aurora/scheduler/events/Webhook.java (line 58)
<https://reviews.apache.org/r/47440/#comment199533>

    Done.



src/main/java/org/apache/aurora/scheduler/events/Webhook.java (line 59)
<https://reviews.apache.org/r/47440/#comment199481>

    Kafka Proxy requires this to be here. I also didn't see harm in adding it. It's not a
straitforward header as it's dynamic but if you want, I can make it optional by adding to
headers config with a key:value to be filled in later in code
    
    ```
    {
      "headers": {
        "Content-Type": "application/vnd.kafka.json.v1+json",
        "Producer-Type": "reliable",
        "Timestamp": "Timestamp"
      },
      "targetURL": "http://localhost:5000/"
    }
    ```
    
    And then add a property if it's configured. How does that sound? Or we can keep it as
is. LMK.



src/main/java/org/apache/aurora/scheduler/events/Webhook.java (line 60)
<https://reviews.apache.org/r/47440/#comment199532>

    Removing. This looks to be unncessary.



src/main/java/org/apache/aurora/scheduler/events/Webhook.java (line 71)
<https://reviews.apache.org/r/47440/#comment199482>

    Done.



src/main/java/org/apache/aurora/scheduler/events/Webhook.java (line 80)
<https://reviews.apache.org/r/47440/#comment199483>

    Done.



src/main/java/org/apache/aurora/scheduler/events/Webhook.java (lines 82 - 84)
<https://reviews.apache.org/r/47440/#comment199484>

    Yea, they are needed to close the connection. Otherwise connection stays open waiting
for input to be read.
    
    I added inline close statements.



src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java (line 27)
<https://reviews.apache.org/r/47440/#comment199487>

    Done.



src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java (line 42)
<https://reviews.apache.org/r/47440/#comment199489>

    Done.



src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java (line 45)
<https://reviews.apache.org/r/47440/#comment199486>

    It's in a separate path eg tiers.json. Is that OK? It's not mixed in with the code.



src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java (line 73)
<https://reviews.apache.org/r/47440/#comment199485>

    Done.


- Dmitriy Shirchenko


On May 22, 2016, 1:29 p.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47440/
> -----------------------------------------------------------
> 
> (Updated May 22, 2016, 1:29 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Stephan Erb.
> 
> 
> Bugs: AURORA-1683
>     https://issues.apache.org/jira/browse/AURORA-1683
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Looking for some feedback whether I'm on the correct path in adding a webhook. All comments
are welcome!
> 
> 
> Diffs
> -----
> 
>   docs/reference/scheduler-configuration.md f7d676d0ed6bc536f4341dbb9365cf50e8607efb

>   examples/vagrant/upstart/aurora-scheduler.conf 3d9e706de564df5e24cb34265bebc0db1cad11a0

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 9ebfe230836e88a97bc60092373f72f176a8f6f2

>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2a4c0665e48d30e0655de00bd7f6f9b49f01eafc

>   src/main/java/org/apache/aurora/scheduler/events/Webhook.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47440/diff/
> 
> 
> Testing
> -------
> 
> Need to fix tests.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message