aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Shirchenko <cald...@gmail.com>
Subject Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint
Date Wed, 18 May 2016 21:12:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47440/
-----------------------------------------------------------

(Updated May 18, 2016, 9:12 p.m.)


Review request for Aurora.


Bugs: AURORA-1683
    https://issues.apache.org/jira/browse/AURORA-1683


Repository: aurora


Description
-------

Looking for some feedback whether I'm on the correct path in adding a webhook. All comments
are welcome!


Diffs (updated)
-----

  docs/reference/scheduler-configuration.md f7d676d0ed6bc536f4341dbb9365cf50e8607efb 
  examples/vagrant/upstart/aurora-scheduler.conf 3d9e706de564df5e24cb34265bebc0db1cad11a0

  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 9ebfe230836e88a97bc60092373f72f176a8f6f2

  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2a4c0665e48d30e0655de00bd7f6f9b49f01eafc

  src/main/java/org/apache/aurora/scheduler/events/Webhook.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/47440/diff/


Testing
-------

Need to fix tests.


Thanks,

Dmitriy Shirchenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message