aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Shirchenko <cald...@gmail.com>
Subject Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint
Date Tue, 17 May 2016 03:03:07 GMT


> On May 17, 2016, 2:51 a.m., George Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 86
> > <https://reviews.apache.org/r/47440/diff/1/?file=1385132#file1385132line86>
> >
> >     Should this be dispatched on another thread or added to a queue for future delivery?
AFAICT the distribution of events is synchronous, so it seems like operations that might block
for any significant amount of time could cause issues.

Yea, I'm not sure. Do you have examples of best practices on how to dispatch to another thread?


> On May 17, 2016, 2:51 a.m., George Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java, line 17
> > <https://reviews.apache.org/r/47440/diff/1/?file=1385133#file1385133line17>
> >
> >     Should this structure be more generic (perhaps a list of key/values for headers)?
It seems very tied to Kafka as-is.

Good point. Yea, I will switch to a more generic config. Thanks.


- Dmitriy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47440/#review133482
-----------------------------------------------------------


On May 17, 2016, 2:10 a.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47440/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 2:10 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-1683
>     https://issues.apache.org/jira/browse/AURORA-1683
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Looking for some feedback whether I'm on the correct path in adding a webhook. All comments
are welcome!
> 
> 
> Diffs
> -----
> 
>   docs/reference/scheduler-configuration.md f7d676d0ed6bc536f4341dbb9365cf50e8607efb

>   examples/vagrant/upstart/aurora-scheduler.conf 3d9e706de564df5e24cb34265bebc0db1cad11a0

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 9ebfe230836e88a97bc60092373f72f176a8f6f2

>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2a4c0665e48d30e0655de00bd7f6f9b49f01eafc

>   src/main/java/org/apache/aurora/scheduler/events/Webhook.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47440/diff/
> 
> 
> Testing
> -------
> 
> Need to fix tests.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message