aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <ma...@apache.org>
Subject Re: Review Request 47373: Batching explicit task reconciliation calls
Date Mon, 16 May 2016 17:13:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47373/
-----------------------------------------------------------

(Updated May 16, 2016, 5:13 p.m.)


Review request for Aurora, Joshua Cohen and Stephan Erb.


Changes
-------

Stephan's comments.


Repository: aurora


Description
-------

This helps alleviate master task reconciliation pressure in large clusters that _may_ lead
to unresponsiveness and subsequent loss of slaves given a combination of other load factors.

Default values are chosen somewhat randomly but have been battle tested. Happy to consider
other suggestions.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java cccee083fc2e5f204c91a9d397beb451d4d9df40

  src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 57d20618fe9eda076936d159172d5e133ec6597b

  src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java 5b4b3ac9781c9b572bbc9507c238dfa3b0177b45

  src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 9082a31d4d2ff454775f5160a474e31261628929


Diff: https://reviews.apache.org/r/47373/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message