aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.
Date Fri, 06 May 2016 01:54:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47050/#review131981
-----------------------------------------------------------



I put some effort into to supporting feathered RBs, you can put 46997 in the `depends on`
field and the AuroraBot will apply its diff 1st, then this diff on top... currently only works
for 1 parent.

- John Sirois


On May 5, 2016, 7:51 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47050/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 7:51 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Migrating some `ResourceSlot` customers to `ResourceBag`. The selection here is somewhat
arbitrary to minimize the diff size.
> 
> Will NOT apply cleanly. Branched off of https://reviews.apache.org/r/46997.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java
501e6431f21822d9816952377546586da02ce42a 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1ee2cfa231d32d91b620dddd7aee6c1047424cb3

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 6b5b12bce8052b93e921d060dd0e196b2554eefd

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java b325106c7f45b1ad1657221aaa39e3a428719ab0

>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 98be997b0343de85d3c376a770d574437ede69a6

>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java 9a37ee7a99818138e53a6d4665e0b09930d1cd45

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 3437c65af27993ea50bf39d322558fb64a645da1

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java bf476aa3d5647be45b2525965e735d80dbfbf0f4

>   src/main/java/org/apache/aurora/scheduler/resources/ResourceBag.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 1b88fc3178c44c5e21a9e5ffb432bddbf8f7098f

>   src/main/java/org/apache/aurora/scheduler/resources/ResourceSlot.java a8dee95df8fd2a5a7546618ebdbc3cce7dabf8c3

>   src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java 2c044a625b52ef0303b2eff08fc946b6b4b36036

>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 1a3886f9018160fc9daeefcd9470cccb95bccd07

>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 03dfa27a701e26415753006574aae62297c09660

>   src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
1474fa90eab3d018a499e8aefc7f9266e892f72a 
>   src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 94a885fae8179f0f52bff6985fd9052b857f6b6f

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java ad397c6924b025f1eefb2bb02a6dc1e1f10ca078

>   src/test/java/org/apache/aurora/scheduler/mesos/Offers.java b266554b19a571f794edcc1aefa8571f1c406891

>   src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java
4efa696b6ee196837f775349a9b2b8f655fa4575 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceBagTest.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java c53a21d127a58fe90f4974d62afb613805f121f0

>   src/test/java/org/apache/aurora/scheduler/resources/ResourceSlotTest.java 0e6a5ac911a1975f3ace4fa62fdb76b39b8a62b0

>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 821c47fae50077959cd8a60e24b6be24f9e2c928

>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java ca10323b8b0a1d2b63bc3e502a94f660a1a9dade

> 
> Diff: https://reviews.apache.org/r/47050/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message