Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 88DC4196B4 for ; Thu, 28 Apr 2016 16:29:54 +0000 (UTC) Received: (qmail 87167 invoked by uid 500); 28 Apr 2016 16:29:54 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 87114 invoked by uid 500); 28 Apr 2016 16:29:54 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 87079 invoked by uid 99); 28 Apr 2016 16:29:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Apr 2016 16:29:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 38AA42B3BE6; Thu, 28 Apr 2016 16:29:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7536991094698953827==" MIME-Version: 1.0 Subject: Re: Review Request 46786: Add missing Mesos dependency to packer build script. From: Joshua Cohen To: John Sirois , Stephan Erb Cc: Joshua Cohen , Aurora ReviewBot , Maxim Khutornenko , Aurora Date: Thu, 28 Apr 2016 16:29:49 -0000 Message-ID: <20160428162949.26230.29676@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joshua Cohen X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46786/ X-Sender: Joshua Cohen References: <20160428160215.26230.59393@reviews.apache.org> In-Reply-To: <20160428160215.26230.59393@reviews.apache.org> Reply-To: Joshua Cohen X-ReviewRequest-Repository: aurora --===============7536991094698953827== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 28, 2016, 4:02 p.m., John Sirois wrote: > > build-support/packer/build.sh, line 37 > > > > > > Try default-jre-headless?: https://launchpad.net/ubuntu/trusty/+package/default-jre-headless Looks like default-jre-headless will work. > On April 28, 2016, 4:02 p.m., John Sirois wrote: > > build-support/packer/build.sh, line 44 > > > > > > I'm missing how this is needed too. If I remove this we don't have a jdk in the vagrant image and therefore can't build the scheduler. I.e., I guess default-jre-headless brings in only the JRE but not the JDK? - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130929 ----------------------------------------------------------- On April 28, 2016, 3:48 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46786/ > ----------------------------------------------------------- > > (Updated April 28, 2016, 3:48 p.m.) > > > Review request for Aurora, John Sirois and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > See http://markmail.org/message/rofuiaclgkesfx3o for full details. > > > Diffs > ----- > > build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9 > > Diff: https://reviews.apache.org/r/46786/diff/ > > > Testing > ------- > > Successfully built base box with these changes. > > > Thanks, > > Joshua Cohen > > --===============7536991094698953827==--