Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE50319504 for ; Mon, 25 Apr 2016 17:42:18 +0000 (UTC) Received: (qmail 20395 invoked by uid 500); 25 Apr 2016 17:42:18 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 20343 invoked by uid 500); 25 Apr 2016 17:42:18 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 20320 invoked by uid 99); 25 Apr 2016 17:42:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Apr 2016 17:42:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A5BFB2B2CD0; Mon, 25 Apr 2016 17:42:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8526760821923582819==" MIME-Version: 1.0 Subject: Re: Review Request 46596: Command line flag to change FrameworkInfo.name From: Zameer Manji To: Maxim Khutornenko , Zameer Manji Cc: Aurora , Stephan Erb Date: Mon, 25 Apr 2016 17:42:13 -0000 Message-ID: <20160425174213.26196.77623@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zameer Manji X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46596/ X-Sender: Zameer Manji X-ReviewBoard-ShipIt: 1 References: <20160423003837.8135.70540@reviews.apache.org> In-Reply-To: <20160423003837.8135.70540@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Zameer Manji X-ReviewRequest-Repository: aurora --===============8526760821923582819== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/#review130468 ----------------------------------------------------------- Ship it! Ship It! - Zameer Manji On April 22, 2016, 5:38 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46596/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 5:38 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-945 > https://issues.apache.org/jira/browse/AURORA-945 > > > Repository: aurora > > > Description > ------- > > This commit introduces a new command line flag `-framework_name` and changes the value from the hardcoded 'TwitterScheduler' to 'aurora'. > > This change is non-intrusive as https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new value will be shown on the UI and used for Mesos DNS. I have skipped a deprecation cycle for this change, as if an operator wants to maintain the old value, he can simply use the new option when deploying the next Aurora version. > > > Diffs > ----- > > RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 > docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 > docs/reference/scheduler-configuration.md d2262f79edfde23eccd87bae7f1cf319b63b1103 > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 > src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java dc964b8dac1b8e21e86ad331216c57fa11abeb6d > > Diff: https://reviews.apache.org/r/46596/diff/ > > > Testing > ------- > > * ./gradlew -Pq build > * Changed the framework name in vagrant. Aurora happily re-registered without a fallout. > > > Thanks, > > Stephan Erb > > --===============8526760821923582819==--