Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DD28518095 for ; Wed, 20 Apr 2016 21:38:56 +0000 (UTC) Received: (qmail 55551 invoked by uid 500); 20 Apr 2016 21:38:51 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 55502 invoked by uid 500); 20 Apr 2016 21:38:51 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 55432 invoked by uid 99); 20 Apr 2016 21:38:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Apr 2016 21:38:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2C1572B1C47; Wed, 20 Apr 2016 21:38:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0903489247360787234==" MIME-Version: 1.0 Subject: Re: Review Request 45298: Remove some dependencies linked to docker usage From: Pierre Cheynier To: John Sirois Cc: Aurora , Pierre Cheynier Date: Wed, 20 Apr 2016 21:38:47 -0000 Message-ID: <20160420213847.8130.87220@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Pierre Cheynier X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45298/ X-Sender: Pierre Cheynier References: <20160419233453.8129.90721@reviews.apache.org> In-Reply-To: <20160419233453.8129.90721@reviews.apache.org> X-ReviewBoard-Diff-For: specs/rpm/SOURCES/aurora-pants.ini X-ReviewBoard-Diff-For: specs/debian/aurora-pants.ini X-ReviewBoard-Diff-For: builder/rpm/centos-7/pants.ini X-ReviewBoard-Diff-For: builder/deb/ubuntu-trusty/pants.ini X-ReviewBoard-Diff-For: builder/deb/debian-jessie/pants.ini Reply-To: Pierre Cheynier X-ReviewRequest-Repository: aurora-packaging --===============0903489247360787234== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45298/ ----------------------------------------------------------- (Updated April 20, 2016, 3:38 p.m.) Review request for Aurora and John Sirois. Bugs: AURORA-1568 https://issues.apache.org/jira/browse/AURORA-1568 Repository: aurora-packaging Description ------- An operator should be able to build Aurora on his platform without relying on Docker. Even if this is an interesting way of doing it, it sometimes introduce missed (build-)dependencies (in this case openssl) and context-specific behaviour (here, the way pants.ini was added to the build context) Diffs ----- builder/deb/debian-jessie/Dockerfile fd15dfe6fd4518cfe9915b7339c1b3e609e968d7 builder/deb/debian-jessie/pants.ini 446ea8d8ebb4fce2665dc4c7c1a2ea32d5f18707 builder/deb/ubuntu-trusty/Dockerfile a4a9e648537841583fdc02c006bfa00a3a095aca builder/deb/ubuntu-trusty/pants.ini builder/rpm/centos-7/Dockerfile a4d9dfcee5637d23333c31d0c2b63a9ebcf04e8d builder/rpm/centos-7/pants.ini specs/debian/control 9dd927df63f68afc10506a7dcab8d26f21fbee33 specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d specs/rpm/Makefile 0476bcbda489bf53edc2101831475fe4a4ea3241 specs/rpm/aurora.spec fa89242f0c39ca058bc791dab18f67f75150e2d2 Diff: https://reviews.apache.org/r/45298/diff/ Testing ------- Able to build on CentOS 6 using mock. Able to build on Debian. Limitation = need the patched version of Gradle. Still able to build using the current Docker build system Thanks, Pierre Cheynier --===============0903489247360787234==--