Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8B0C519A31 for ; Mon, 18 Apr 2016 19:02:43 +0000 (UTC) Received: (qmail 16073 invoked by uid 500); 18 Apr 2016 19:02:43 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 16026 invoked by uid 500); 18 Apr 2016 19:02:43 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 16000 invoked by uid 99); 18 Apr 2016 19:02:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Apr 2016 19:02:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4A73C2B0E7C; Mon, 18 Apr 2016 19:02:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3135615562736243801==" MIME-Version: 1.0 Subject: Re: Review Request 46290: Adding a flag to control whether the executor runs health checks as the job's role's user From: Dmitriy Shirchenko To: Bill Farner , Zameer Manji Cc: Dmitriy Shirchenko , Aurora , Joshua Cohen , Aurora ReviewBot Date: Mon, 18 Apr 2016 19:02:39 -0000 Message-ID: <20160418190239.8130.77353@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Dmitriy Shirchenko X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46290/ X-Sender: Dmitriy Shirchenko References: <20160418190137.8135.5196@reviews.apache.org> In-Reply-To: <20160418190137.8135.5196@reviews.apache.org> Reply-To: Dmitriy Shirchenko X-ReviewRequest-Repository: aurora --===============3135615562736243801== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46290/ ----------------------------------------------------------- (Updated April 18, 2016, 7:02 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1666 https://issues.apache.org/jira/browse/AURORA-1666 Repository: aurora Description ------- Adding a flag to control whether the executor runs health checks as the job's role's user Diffs (updated) ----- RELEASE-NOTES.md 99d261b7928576f91d4b69bdc6be7210578ee7b3 src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 40a0cd6396a78c591debf5e2be11363ecf496231 src/main/python/apache/aurora/executor/common/health_checker.py d8675beb8f16ebdd2d6946367784411fe84a5cfc src/test/python/apache/aurora/executor/common/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing ------- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko --===============3135615562736243801==--