Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0319119614 for ; Mon, 18 Apr 2016 17:47:57 +0000 (UTC) Received: (qmail 28631 invoked by uid 500); 18 Apr 2016 17:47:57 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 28575 invoked by uid 500); 18 Apr 2016 17:47:56 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 28553 invoked by uid 99); 18 Apr 2016 17:47:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Apr 2016 17:47:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7866C2B0F27; Mon, 18 Apr 2016 17:47:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0551279997624819351==" MIME-Version: 1.0 Subject: Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role From: Zameer Manji To: Bill Farner , Zameer Manji Cc: Dmitriy Shirchenko , Aurora Date: Mon, 18 Apr 2016 17:47:52 -0000 Message-ID: <20160418174752.8130.38934@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zameer Manji X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46290/ X-Sender: Zameer Manji X-ReviewBoard-ShipIt: 1 References: <20160415235957.29093.41583@reviews.apache.org> In-Reply-To: <20160415235957.29093.41583@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Zameer Manji X-ReviewRequest-Repository: aurora --===============0551279997624819351== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46290/#review129375 ----------------------------------------------------------- Ship it! Ship It! - Zameer Manji On April 15, 2016, 4:59 p.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46290/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 4:59 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1666 > https://issues.apache.org/jira/browse/AURORA-1666 > > > Repository: aurora > > > Description > ------- > > adding do-not-demote-health-check-to-role flag to not demote health check user:group to role > > > Diffs > ----- > > RELEASE-NOTES.md a0536ec352119952d4d58aa5f36e5e9a7b7d2e6e > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 40a0cd6396a78c591debf5e2be11363ecf496231 > src/main/python/apache/aurora/executor/common/health_checker.py d8675beb8f16ebdd2d6946367784411fe84a5cfc > src/test/python/apache/aurora/executor/common/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a > > Diff: https://reviews.apache.org/r/46290/diff/ > > > Testing > ------- > > - end to end tests > - added unit tests > > > Thanks, > > Dmitriy Shirchenko > > --===============0551279997624819351==--