Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3C2DD19504 for ; Wed, 13 Apr 2016 15:09:14 +0000 (UTC) Received: (qmail 88324 invoked by uid 500); 13 Apr 2016 15:09:13 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 88272 invoked by uid 500); 13 Apr 2016 15:09:13 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 88249 invoked by uid 99); 13 Apr 2016 15:09:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Apr 2016 15:09:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E11F62B002F; Wed, 13 Apr 2016 15:09:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7086823477862934521==" MIME-Version: 1.0 Subject: Re: Review Request 46133: Simplify `Credentials`; kill `ZooKeeperClient` dep. From: John Sirois To: Bill Farner , Zameer Manji Cc: Aurora , John Sirois , Aurora ReviewBot Date: Wed, 13 Apr 2016 15:09:09 -0000 Message-ID: <20160413150909.29094.86808@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: John Sirois X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46133/ X-Sender: John Sirois References: <20160413150437.29093.13730@reviews.apache.org> In-Reply-To: <20160413150437.29093.13730@reviews.apache.org> X-ReviewBoard-Diff-For: commons/src/main/java/org/apache/aurora/common/zookeeper/Credentials.java Reply-To: John Sirois X-ReviewRequest-Repository: aurora --===============7086823477862934521== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 13, 2016, 9:04 a.m., Bill Farner wrote: > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java, line 405 > > > > > > s/this.// Fixed. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46133/#review128688 ----------------------------------------------------------- On April 12, 2016, 8:18 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46133/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 8:18 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1468 > https://issues.apache.org/jira/browse/AURORA-1468 > > > Repository: aurora > > > Description > ------- > > The Curator discovery code will need to be configured from the same > command line flags and code as the commons discovery code. This > simplifies Credentials to be a simple struct and adapts from the > `Credentials.NONE` null-object to use of `Optional` in consumers. > > commons/src/main/java/org/apache/aurora/common/zookeeper/Credentials.java | 90 +++++++++++++++++++++++++++++++ > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java | 147 ++++++-------------------------------------------- > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java | 15 +++--- > commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java | 3 +- > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java | 37 +------------ > src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java | 13 ++--- > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 30 +++++++---- > src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/ZooKeeperClientModule.java | 21 +++++--- > src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/flagged/FlaggedClientConfig.java | 20 +++---- > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java | 6 +-- > 10 files changed, 172 insertions(+), 210 deletions(-) > > > Diffs > ----- > > commons/src/main/java/org/apache/aurora/common/zookeeper/Credentials.java PRE-CREATION > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 41ae035bdd780027f459ec42c39fb6190a963182 > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java b9eaedb1f6740fdaf65bd0fa2613d4dd914536f7 > commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 9127b6e569618f30b74bae2fc7665a92bc30d735 > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java 537d41e2f6a2d56318e50219c8d848a0e253ecd5 > src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java c14162fa59bec41e00d8604e7659ca3b925f7a23 > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 5daafa9234d20dfcfd9a6cc81508836efe39f1f0 > src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/ZooKeeperClientModule.java 4239a867119699267ff8e663a2827feb751fbb79 > src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/flagged/FlaggedClientConfig.java 5b59d55b8e58d0231a18da9813045a9d1dd70be3 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 89b2813773c2c4bf211883e9d67592b37852776c > > Diff: https://reviews.apache.org/r/46133/diff/ > > > Testing > ------- > > Locally green: > ``` > ./gradlew -Pq build > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > > --===============7086823477862934521==--